-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swift5: merge eval_ast, fix metadata, use Debian compiler #693
Conversation
I wonder why Debian packages |
415594c
to
1047716
Compare
@asarhaddon I was able to get the file to build and everything to compile and tests to pass using the following adjustment to the Dockerfile:
However, note that this is actually swiftc version 6. We could probably just rename this implementation to Swift 6. |
For the rpython implementation, I think there is at least a missing comma between "nil" and "false" in the DEBUG-EVAL conditional. |
ebdaca0
to
2de2a31
Compare
I think modifying the .travis.yml file is triggering the full build of all the implementations. I had honestly forgotten that we still had that file. We should just remove it. For now though, I would just revert it so that builds are just for swift6 and we can remove the file separately later. |
BTW, I think you can probably fix the swift6 failure by setting HOME to /mal in the Dockerfile so that it has a place that it can write cache files to. |
2de2a31
to
cdd7291
Compare
This implementation is completed, although not listed yet in #657 :-)