fix: fix unintentional children mutation

[marianyp]

In #562, a setter method for the parent property was introduced. This setter uses a .splice call to modify the children of the game object. However, in the remove game object method, we first set the parent to null, which triggers 1 splice call. Immediately after setting the parent to null, we perform another splice call. This is problematic because it results in 2 game objects being removed instead of 1.

Steps to reproduce:

• Use the current master branch
• Create a game with at least 2 game objects.
• Delete the game object that was created first

Example:

const a = add([
	text("test 1", {
		size: 50
	}),
	color("#ff0000"),
	pos(width() / 2, height() / 2),
	fixed()
])

const b = add([
	text("test 2", {
		size: 50
	}),
	color("#ff0000"),
	pos(width() / 2, height() / 2 + 50),
	fixed()
])

a.destroy() // Results in both A and B being deleted

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/kaplayjs/kaplay@586

commit: 1eb67d9