-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New 661k HQ indexes, COBS installation, make test and CI #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@karel-brinda I did not understand the meaning of things like:
Now I understand it can be used for load balancing! Never saw this is |
... dont want to get billed by GH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry again for a PR that does many things.
Main changes:
gcc-11
installed, you have tobrew
install it: I don't think this is the ideal solution, but should work for all linux, and the big majority of Mac. Closes Looking for alternate ways to install COBS on Mac #35 but opens Improve COBS delivery with a conda or homebrew recipe #39make test
command thatmof-search
the query against 3 batches only to quickly check if the full pipeline works;Minor changes:
decomp_thr
anddownload_thr
fromconfig.yaml
, and addedcobs_thr
. All downloads are made with a fixed 1 thread,xz
decompression andcobs
are run withcobs_thr
threads;yq
is only used to get a single parameter from config.yaml. Replacedyq
with agrep
andawk
to reduce dependencies;fix_query
rule not working on Mac (sed
on mac is different fromsed
on linux);minimap2
conda env;brew install gcc-11
, updated dependencies, added a walkthrough