Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix version regex in the CLI test case #3742

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

devoto13
Copy link
Collaborator

\d no longer matches since 6.3.10 because of two-digit number.

\d no longer matches since 6.3.10 because of two-digit number.
@devoto13
Copy link
Collaborator Author

devoto13 commented Jan 10, 2022

@jginsburgn This should fix CI in #3741, but then Integration tests need to be fixed (or temporarily disabled) for this to pass and I'm pretty sure semantic-release will fail because it also depends on the bad colors version, so we'll need to update NPM on CI for the overrides keyword from #3741 to work as it was introduced in NPM 8 only. I can pick it up tonight if you don't have time to look into it earlier.

@devoto13
Copy link
Collaborator Author

devoto13 commented Jan 10, 2022

@jginsburgn Pushed two more commits. The CI is green and I think the hotfix release should succeed once this is merged. Turns out NPM 6 already dedupes all colors packages into 1.4.0, so no NPM upgrade was needed.

@jginsburgn jginsburgn merged commit de0df2f into karma-runner:master Jan 13, 2022
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.3.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@devoto13 devoto13 deleted the fix-test branch January 14, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants