-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit tests for safe lua lifted libraries #5819
base: master
Are you sure you want to change the base?
Added unit tests for safe lua lifted libraries #5819
Conversation
Signed-off-by: Anuj Agrawal <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5819 +/- ##
==========================================
+ Coverage 43.16% 43.28% +0.12%
==========================================
Files 658 658
Lines 56006 56006
==========================================
+ Hits 24173 24244 +71
+ Misses 30263 30191 -72
- Partials 1570 1571 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/cc @zhzhuang-zju |
/assign |
lua "github.com/yuin/gopher-lua" | ||
) | ||
|
||
func TestOpenSafeOs(t *testing.T) { | ||
L := lua.NewState() | ||
defer L.Close() | ||
|
||
expect := 1 | ||
assert.Equal(t, 1, OpenSafeOs(L)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
Description:
This PR introduces comprehensive unit tests for the safe Lua library utility functions in the pkg/util/lifted/lua package. These additions aim to increase code reliability, maintainability, and test coverage for the Lua libraries lifted from argo-cd and gopher-lua.
Additions & Modifications:
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: