Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for safe lua lifted libraries #5819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR introduces comprehensive unit tests for the safe Lua library utility functions in the pkg/util/lifted/lua package. These additions aim to increase code reliability, maintainability, and test coverage for the Lua libraries lifted from argo-cd and gopher-lua.

Additions & Modifications:

  1. pkg/util/lifted/lua/loadlib_safe_test.go
  2. pkg/util/lifted/lua/oslib_safe_test.go

Test Coverage:

  1. pkg/util/lifted/lua/loadlib_safe_test.go : 0% to 95.80%
  2. pkg/util/lifted/lua/oslib_safe_test.go : 52.14% to 94.50%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 14, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.28%. Comparing base (e08cea1) to head (efff5bc).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5819      +/-   ##
==========================================
+ Coverage   43.16%   43.28%   +0.12%     
==========================================
  Files         658      658              
  Lines       56006    56006              
==========================================
+ Hits        24173    24244      +71     
+ Misses      30263    30191      -72     
- Partials     1570     1571       +1     
Flag Coverage Δ
unittests 43.28% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

/cc @zhzhuang-zju

@XiShanYongYe-Chang
Copy link
Member

/assign

lua "github.com/yuin/gopher-lua"
)

func TestOpenSafeOs(t *testing.T) {
L := lua.NewState()
defer L.Close()

expect := 1
assert.Equal(t, 1, OpenSafeOs(L))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants