Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: translate zh/docs/tutorials/autoscaling-with-resource-metrics/ #601

Merged
merged 3 commits into from
May 11, 2024
Merged

doc: translate zh/docs/tutorials/autoscaling-with-resource-metrics/ #601

merged 3 commits into from
May 11, 2024

Conversation

B1F030
Copy link
Contributor

@B1F030 B1F030 commented May 11, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:
translate zh/docs/tutorials/autoscaling-with-resource-metrics/

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 11, 2024
@karmada-bot karmada-bot requested review from samzong and windsonsea May 11, 2024 08:43
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2024
@B1F030
Copy link
Contributor Author

B1F030 commented May 11, 2024

/cc @zhzhuang-zju

@karmada-bot karmada-bot requested a review from zhzhuang-zju May 11, 2024 08:44
windsonsea
windsonsea reviewed May 11, 2024
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for discussion

i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
@B1F030
review fix
cd9e43b 
Signed-off-by: B1F030 <[email protected]>
windsonsea
windsonsea reviewed May 11, 2024
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM for the text. I'm not sure if it's necessary to squash all the commits into a single one.
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2024
zhzhuang-zju
zhzhuang-zju reviewed May 11, 2024
View reviewed changes
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution~
Just a few little things to make the sentences flow better

i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-resource-metrics.md Outdated Show resolved Hide resolved
@B1F030
review
a249646 
Signed-off-by: B1F030 <[email protected]>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2024
RainbowMango
RainbowMango approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2024
@karmada-bot karmada-bot merged commit f01f46b into karmada-io:main May 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windsonsea windsonsea windsonsea left review comments

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@samzong samzong Awaiting requested review from samzong

Assignees

@RainbowMango RainbowMango

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@B1F030 @karmada-bot @RainbowMango @windsonsea @zhzhuang-zju