Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: make serve unavailable #793

Closed
wants to merge 1 commit into from
Closed

Conversation

fleeto
Copy link
Member

@fleeto fleeto commented Feb 8, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Due to an error in the Dockerfile, the make serve command could not be completed. I adjusted the order of some instructions to fix the issue.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 8, 2025
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2025
Signed-off-by: Vincent Cui <[email protected]>
Signed-off-by: Vincent Cui <[email protected]>
@RainbowMango
Copy link
Member

@samzong Please take a look~

Copy link
Contributor

@pigletfly pigletfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pigletfly
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango
Copy link
Member

@pigletfly So glad to hear from you! Long time no see, I hope you are doing well!

@fleeto
Copy link
Member Author

fleeto commented Feb 8, 2025

echo "Docker image karmada-website:v0.1.0 exists"
Docker image karmada-website:v0.1.0 exists
docker run --rm -it --name karmada-website \
                -v /tmp/website:/app/docs \
                --workdir=/app/docs \
                -p 3000:3000 \
                karmada-website:v0.1.0
yarn run v1.22.22
$ docusaurus start --host 0.0.0.0 && sh start-watch.sh
/bin/sh: docusaurus: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [serve] Error 127

asciinema

@samzong
Copy link
Member

samzong commented Feb 8, 2025

image

@fleeto Thanks for finding a bug, But i run at local for PR, it's failed.

can u help me?

@fleeto
Copy link
Member Author

fleeto commented Feb 8, 2025

This is caused by the cache referenced by docker build.

@fleeto fleeto closed this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants