update PDG identifiers to use latex description

* ref: cern-sis/issues-inspire#471
karolina-siemieniuk-morawska · Jun 10, 2024 · bfe7472 · bfe7472
1 parent 7aab90e
commit bfe7472
Show file tree

Hide file tree

Showing 8 changed files with 19,964 additions and 11,399 deletions.
diff --git a/backend/inspirehep/records/marshmallow/literature/pdg_identifiers.py b/backend/inspirehep/records/marshmallow/literature/pdg_identifiers.py
diff --git a/backend/inspirehep/records/marshmallow/literature/pdg_identifiers_latex.py b/backend/inspirehep/records/marshmallow/literature/pdg_identifiers_latex.py
diff --git a/backend/inspirehep/records/marshmallow/literature/ui.py b/backend/inspirehep/records/marshmallow/literature/ui.py
@@ -43,7 +43,7 @@
     PublicationInfoItemSchemaV1,
     ThesisInfoSchemaV1,
 )
-from .pdg_identifiers import PDG_IDS_TO_DESCRIPTION_MAPPING
+from .pdg_identifiers_latex import PDG_IDS_TO_LATEX_DESCRIPTION_MAPPING
 
 DATASET_SCHEMA_TO_URL_PREFIX_MAP = {
     "hepdata": "https://www.hepdata.net/record/",
@@ -285,7 +285,7 @@ def get_pdg_keywords(self, data):
             pdg_keywords.append(
                 {
                     "value": pdg_identifier,
-                    "description": PDG_IDS_TO_DESCRIPTION_MAPPING[pdg_identifier],
+                    "description": PDG_IDS_TO_LATEX_DESCRIPTION_MAPPING[pdg_identifier],
                 }
             )
 

diff --git a/backend/tests/integration-async/curation/test_curation_cli.py b/backend/tests/integration-async/curation/test_curation_cli.py
@@ -19,7 +19,7 @@
 
 
 @mock.patch(
-    "inspirehep.records.marshmallow.literature.ui.PDG_IDS_TO_DESCRIPTION_MAPPING",
+    "inspirehep.records.marshmallow.literature.ui.PDG_IDS_TO_LATEX_DESCRIPTION_MAPPING",
     {
         "S000": "gamma (photon)",
         "S000.99": "test",
@@ -134,7 +134,7 @@ def assert_keywords_are_updated():
 
 
 @mock.patch(
-    "inspirehep.records.marshmallow.literature.ui.PDG_IDS_TO_DESCRIPTION_MAPPING",
+    "inspirehep.records.marshmallow.literature.ui.PDG_IDS_TO_LATEX_DESCRIPTION_MAPPING",
     {
         "S000": "gamma (photon)",
         "S000.99": "test",

diff --git a/backend/tests/unit/records/marshmallow/literature/test_ui.py b/backend/tests/unit/records/marshmallow/literature/test_ui.py
@@ -280,29 +280,32 @@ def test_documents_doesnt_contain_error_from_fulltext(
     serialized = serializer.dump(entry_data).data
     assert "_error" not in serialized
 
+
 def test_filter_non_pdg_keywords():
     data = {
         "keywords": [
-            { "schema": "PDG", "source": "PDG", "value": "M013WX" },
-            { "source": "publisher", "value": "Strong Interactions" },
+            {"schema": "PDG", "source": "PDG", "value": "M013WX"},
+            {"source": "publisher", "value": "Strong Interactions"},
         ]
     }
-    expected_data = [
-        { "source": "publisher", "value": "Strong Interactions" }
-    ]
+    expected_data = [{"source": "publisher", "value": "Strong Interactions"}]
     serializer = LiteratureDetailSchema()
     serialized = serializer.dump(data).data
     assert serialized["keywords"] == expected_data
 
+
 def test_filter_pdg_keywords():
     data = {
         "keywords": [
-            { "schema": "PDG", "source": "PDG", "value": "M013WX" },
-            { "source": "publisher", "value": "Strong Interactions" },
+            {"schema": "PDG", "source": "PDG", "value": "M013WX"},
+            {"source": "publisher", "value": "Strong Interactions"},
         ]
     }
     expected_data = [
-        { "value": "M013WX", "description": "f(2)'(1525) WIDTH" }
+        {
+            "value": "M013WX",
+            "description": "${{\\mathit f}_{{{2}}}^{\\,'}{(1525)}}$ WIDTH",
+        }
     ]
     serializer = LiteratureDetailSchema()
     serialized = serializer.dump(data).data

diff --git a/ui/src/literature/components/PDGKeywords.tsx b/ui/src/literature/components/PDGKeywords.tsx
@@ -3,11 +3,12 @@ import { Modal, List } from 'antd';
 
 import SecondaryButton from '../../common/components/SecondaryButton';
 import LinkWithTargetBlank from '../../common/components/LinkWithTargetBlank';
+import Latex from '../../common/components/Latex';
 
 interface IKeyword {
   get: (arg: string) => string;
   size: number;
-  valueSeq: () => {get: (arg: number) => IKeyword}
+  valueSeq: () => { get: (arg: number) => IKeyword };
 }
 
 export const PDGKeywords = ({ keywords }: { keywords: IKeyword }) => {
@@ -26,10 +27,12 @@ export const PDGKeywords = ({ keywords }: { keywords: IKeyword }) => {
   const renderKeyword = (keyword: IKeyword) => {
     const keywordValue = keyword && keyword.get('value');
     const keywordDescription = keyword && keyword.get('description');
-    
+
     return (
-      <LinkWithTargetBlank href={`https://pdglive.lbl.gov/view/${keywordValue}`}>
-        {keywordDescription}
+      <LinkWithTargetBlank
+        href={`https://pdglive.lbl.gov/view/${keywordValue}`}
+      >
+        <Latex>{keywordDescription}</Latex>
       </LinkWithTargetBlank>
     );
   };
@@ -46,18 +49,20 @@ export const PDGKeywords = ({ keywords }: { keywords: IKeyword }) => {
           open={modalVisibility}
           footer={null}
           onCancel={toggleModal}
-          bodyStyle={{padding: '12px 24px 24px 24px'}}
+          bodyStyle={{ padding: '12px 24px 24px 24px' }}
         >
           <List
             // @ts-ignore
             dataSource={keywords}
             size="small"
             pagination={{
               pageSize: 10,
-              size: "small",
+              size: 'small',
               hideOnSinglePage: true,
             }}
-            renderItem={(keyword: IKeyword) => <List.Item>{renderKeyword(keyword)}</List.Item>}
+            renderItem={(keyword: IKeyword) => (
+              <List.Item>{renderKeyword(keyword)}</List.Item>
+            )}
           />
         </Modal>
       </>

diff --git a/ui/src/literature/components/__tests__/PDGKeywords.test.jsx b/ui/src/literature/components/__tests__/PDGKeywords.test.jsx
@@ -9,11 +9,13 @@ describe('PDGKeywords', () => {
     const keywords = fromJS([
       {
         value: 'Q007TP',
-        description: 'Test description'
+        description:
+          // eslint-disable-next-line no-template-curly-in-string
+          '\\Gamma($  ${{\\mathit W}^{+}}$   $\\rightarrow$   ${{\\mathit \\ell}^{+}}{{\\mathit \\nu}})/\\Gamma_{\\text{total}}',
       },
       {
         value: '2137',
-        description: 'test'
+        description: 'test',
       },
     ]);
     const wrapper = shallow(<PDGKeywords keywords={keywords} />);

diff --git a/ui/src/literature/components/__tests__/__snapshots__/PDGKeywords.test.jsx.snap b/ui/src/literature/components/__tests__/__snapshots__/PDGKeywords.test.jsx.snap
@@ -8,7 +8,9 @@ exports[`PDGKeywords renders with keywords 1`] = `
     as="a"
     href="https://pdglive.lbl.gov/view/Q007TP"
   >
-    Test description
+    <Latex>
+      \\Gamma($  \${{\\mathit W}^{+}}$   $\\rightarrow$   \${{\\mathit \\ell}^{+}}{{\\mathit \\nu}})/\\Gamma_{\\text{total}}
+    </Latex>
   </LinkWithTargetBlank>
   <div
     className="di pl2"
@@ -38,7 +40,7 @@ exports[`PDGKeywords renders with keywords 1`] = `
         Immutable.List [
           Immutable.Map {
             "value": "Q007TP",
-            "description": "Test description",
+            "description": "\\\\Gamma($  \${{\\\\mathit W}^{+}}$   $\\\\rightarrow$   \${{\\\\mathit \\\\ell}^{+}}{{\\\\mathit \\\\nu}})/\\\\Gamma_{\\\\text{total}}",
           },
           Immutable.Map {
             "value": "2137",