Skip to content

Commit

Permalink
Fix typos
Browse files Browse the repository at this point in the history
* retreive -> retrieve
* resposne -> response
  • Loading branch information
Simon-Will committed Dec 7, 2023
1 parent 901dd87 commit 2e6acd8
Show file tree
Hide file tree
Showing 9 changed files with 92 additions and 92 deletions.
20 changes: 10 additions & 10 deletions hishel/_async/_pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ async def handle_async_request(self, request: Request) -> Response:
request.headers.extend([(b"cache-control", b"no-cache"), (b"cache-control", b"max-age=0")])

key = generate_key(request)
stored_data = await self._storage.retreive(key)
stored_data = await self._storage.retrieve(key)

request_cache_control = parse_cache_control(extract_header_values_decoded(request.headers, b"Cache-Control"))

Expand All @@ -66,22 +66,22 @@ async def handle_async_request(self, request: Request) -> Response:
if stored_data:
# Try using the stored response if it was discovered.

stored_resposne, stored_request, metadata = stored_data
stored_response, stored_request, metadata = stored_data

res = self._controller.construct_response_from_cache(
request=request,
response=stored_resposne,
response=stored_response,
original_request=stored_request,
)

if isinstance(res, Response):
# Simply use the response if the controller determines it is ready for use.
metadata["number_of_uses"] += 1
stored_resposne.read()
stored_response.read()
await self._storage.store(
key=key,
request=request,
response=stored_resposne,
response=stored_response,
metadata=metadata,
)
res.extensions["from_cache"] = True # type: ignore[index]
Expand All @@ -97,14 +97,14 @@ async def handle_async_request(self, request: Request) -> Response:
try:
response = await self._pool.handle_async_request(res)
except ConnectError:
if self._controller._allow_stale and allowed_stale(response=stored_resposne):
stored_resposne.extensions["from_cache"] = True # type: ignore[index]
stored_resposne.extensions["cache_metadata"] = metadata # type: ignore[index]
return stored_resposne
if self._controller._allow_stale and allowed_stale(response=stored_response):
stored_response.extensions["from_cache"] = True # type: ignore[index]
stored_response.extensions["cache_metadata"] = metadata # type: ignore[index]
return stored_response
raise # pragma: no cover
# Merge headers with the stale response.
full_response = self._controller.handle_validation_response(
old_response=stored_resposne, new_response=response
old_response=stored_response, new_response=response
)

await full_response.aread()
Expand Down
8 changes: 4 additions & 4 deletions hishel/_async/_storages.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def __init__(
async def store(self, key: str, response: Response, request: Request, metadata: Metadata) -> None:
raise NotImplementedError()

async def retreive(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
async def retrieve(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
raise NotImplementedError()

async def aclose(self) -> None:
Expand Down Expand Up @@ -96,7 +96,7 @@ async def store(self, key: str, response: Response, request: Request, metadata:
)
await self._remove_expired_caches()

async def retreive(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
async def retrieve(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
"""
Retreives the response from the cache using his key.
Expand Down Expand Up @@ -199,7 +199,7 @@ async def store(self, key: str, response: Response, request: Request, metadata:
await self._connection.commit()
await self._remove_expired_caches()

async def retreive(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
async def retrieve(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
"""
Retreives the response from the cache using his key.
Expand Down Expand Up @@ -292,7 +292,7 @@ async def store(self, key: str, response: Response, request: Request, metadata:
key, self._serializer.dumps(response=response, request=request, metadata=metadata), px=px
)

async def retreive(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
async def retrieve(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
"""
Retreives the response from the cache using his key.
Expand Down
30 changes: 15 additions & 15 deletions hishel/_async/_transports.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ async def handle_async_request(self, request: Request) -> Response:
extensions=request.extensions,
)
key = generate_key(httpcore_request)
stored_data = await self._storage.retreive(key)
stored_data = await self._storage.retrieve(key)

request_cache_control = parse_cache_control(
extract_header_values_decoded(request.headers.raw, b"Cache-Control")
Expand All @@ -107,30 +107,30 @@ async def handle_async_request(self, request: Request) -> Response:
if stored_data:
# Try using the stored response if it was discovered.

stored_resposne, stored_request, metadata = stored_data
stored_response, stored_request, metadata = stored_data

res = self._controller.construct_response_from_cache(
request=httpcore_request,
response=stored_resposne,
response=stored_response,
original_request=stored_request,
)

if isinstance(res, httpcore.Response):
# Simply use the response if the controller determines it is ready for use.
metadata["number_of_uses"] += 1
stored_resposne.read()
stored_response.read()
await self._storage.store(
key=key,
request=stored_request,
response=stored_resposne,
response=stored_response,
metadata=metadata,
)
res.extensions["from_cache"] = True # type: ignore[index]
res.extensions["cache_metadata"] = metadata # type: ignore[index]
return Response(
status_code=res.status,
headers=res.headers,
stream=AsyncCacheStream(fake_stream(stored_resposne.content)),
stream=AsyncCacheStream(fake_stream(stored_response.content)),
extensions=res.extensions,
)

Expand All @@ -149,15 +149,15 @@ async def handle_async_request(self, request: Request) -> Response:
try:
response = await self._transport.handle_async_request(revalidation_request)
except ConnectError:
if self._controller._allow_stale and allowed_stale(response=stored_resposne):
await stored_resposne.aread()
stored_resposne.extensions["from_cache"] = True # type: ignore[index]
stored_resposne.extensions["cache_metadata"] = metadata # type: ignore[index]
if self._controller._allow_stale and allowed_stale(response=stored_response):
await stored_response.aread()
stored_response.extensions["from_cache"] = True # type: ignore[index]
stored_response.extensions["cache_metadata"] = metadata # type: ignore[index]
return Response(
status_code=stored_resposne.status,
headers=stored_resposne.headers,
stream=AsyncCacheStream(fake_stream(stored_resposne.content)),
extensions=stored_resposne.extensions,
status_code=stored_response.status,
headers=stored_response.headers,
stream=AsyncCacheStream(fake_stream(stored_response.content)),
extensions=stored_response.extensions,
)
raise # pragma: no cover
assert isinstance(response.stream, tp.AsyncIterable)
Expand All @@ -170,7 +170,7 @@ async def handle_async_request(self, request: Request) -> Response:

# Merge headers with the stale response.
full_response = self._controller.handle_validation_response(
old_response=stored_resposne, new_response=httpcore_response
old_response=stored_response, new_response=httpcore_response
)

await full_response.aread()
Expand Down
20 changes: 10 additions & 10 deletions hishel/_sync/_pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def handle_request(self, request: Request) -> Response:
request.headers.extend([(b"cache-control", b"no-cache"), (b"cache-control", b"max-age=0")])

key = generate_key(request)
stored_data = self._storage.retreive(key)
stored_data = self._storage.retrieve(key)

request_cache_control = parse_cache_control(extract_header_values_decoded(request.headers, b"Cache-Control"))

Expand All @@ -66,22 +66,22 @@ def handle_request(self, request: Request) -> Response:
if stored_data:
# Try using the stored response if it was discovered.

stored_resposne, stored_request, metadata = stored_data
stored_response, stored_request, metadata = stored_data

res = self._controller.construct_response_from_cache(
request=request,
response=stored_resposne,
response=stored_response,
original_request=stored_request,
)

if isinstance(res, Response):
# Simply use the response if the controller determines it is ready for use.
metadata["number_of_uses"] += 1
stored_resposne.read()
stored_response.read()
self._storage.store(
key=key,
request=request,
response=stored_resposne,
response=stored_response,
metadata=metadata,
)
res.extensions["from_cache"] = True # type: ignore[index]
Expand All @@ -97,14 +97,14 @@ def handle_request(self, request: Request) -> Response:
try:
response = self._pool.handle_request(res)
except ConnectError:
if self._controller._allow_stale and allowed_stale(response=stored_resposne):
stored_resposne.extensions["from_cache"] = True # type: ignore[index]
stored_resposne.extensions["cache_metadata"] = metadata # type: ignore[index]
return stored_resposne
if self._controller._allow_stale and allowed_stale(response=stored_response):
stored_response.extensions["from_cache"] = True # type: ignore[index]
stored_response.extensions["cache_metadata"] = metadata # type: ignore[index]
return stored_response
raise # pragma: no cover
# Merge headers with the stale response.
full_response = self._controller.handle_validation_response(
old_response=stored_resposne, new_response=response
old_response=stored_response, new_response=response
)

full_response.read()
Expand Down
8 changes: 4 additions & 4 deletions hishel/_sync/_storages.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def __init__(
def store(self, key: str, response: Response, request: Request, metadata: Metadata) -> None:
raise NotImplementedError()

def retreive(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
def retrieve(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
raise NotImplementedError()

def close(self) -> None:
Expand Down Expand Up @@ -96,7 +96,7 @@ def store(self, key: str, response: Response, request: Request, metadata: Metada
)
self._remove_expired_caches()

def retreive(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
def retrieve(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
"""
Retreives the response from the cache using his key.
Expand Down Expand Up @@ -199,7 +199,7 @@ def store(self, key: str, response: Response, request: Request, metadata: Metada
self._connection.commit()
self._remove_expired_caches()

def retreive(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
def retrieve(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
"""
Retreives the response from the cache using his key.
Expand Down Expand Up @@ -292,7 +292,7 @@ def store(self, key: str, response: Response, request: Request, metadata: Metada
key, self._serializer.dumps(response=response, request=request, metadata=metadata), px=px
)

def retreive(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
def retrieve(self, key: str) -> tp.Optional[tp.Tuple[Response, Request, Metadata]]:
"""
Retreives the response from the cache using his key.
Expand Down
30 changes: 15 additions & 15 deletions hishel/_sync/_transports.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def handle_request(self, request: Request) -> Response:
extensions=request.extensions,
)
key = generate_key(httpcore_request)
stored_data = self._storage.retreive(key)
stored_data = self._storage.retrieve(key)

request_cache_control = parse_cache_control(
extract_header_values_decoded(request.headers.raw, b"Cache-Control")
Expand All @@ -107,30 +107,30 @@ def handle_request(self, request: Request) -> Response:
if stored_data:
# Try using the stored response if it was discovered.

stored_resposne, stored_request, metadata = stored_data
stored_response, stored_request, metadata = stored_data

res = self._controller.construct_response_from_cache(
request=httpcore_request,
response=stored_resposne,
response=stored_response,
original_request=stored_request,
)

if isinstance(res, httpcore.Response):
# Simply use the response if the controller determines it is ready for use.
metadata["number_of_uses"] += 1
stored_resposne.read()
stored_response.read()
self._storage.store(
key=key,
request=stored_request,
response=stored_resposne,
response=stored_response,
metadata=metadata,
)
res.extensions["from_cache"] = True # type: ignore[index]
res.extensions["cache_metadata"] = metadata # type: ignore[index]
return Response(
status_code=res.status,
headers=res.headers,
stream=CacheStream(fake_stream(stored_resposne.content)),
stream=CacheStream(fake_stream(stored_response.content)),
extensions=res.extensions,
)

Expand All @@ -149,15 +149,15 @@ def handle_request(self, request: Request) -> Response:
try:
response = self._transport.handle_request(revalidation_request)
except ConnectError:
if self._controller._allow_stale and allowed_stale(response=stored_resposne):
stored_resposne.read()
stored_resposne.extensions["from_cache"] = True # type: ignore[index]
stored_resposne.extensions["cache_metadata"] = metadata # type: ignore[index]
if self._controller._allow_stale and allowed_stale(response=stored_response):
stored_response.read()
stored_response.extensions["from_cache"] = True # type: ignore[index]
stored_response.extensions["cache_metadata"] = metadata # type: ignore[index]
return Response(
status_code=stored_resposne.status,
headers=stored_resposne.headers,
stream=CacheStream(fake_stream(stored_resposne.content)),
extensions=stored_resposne.extensions,
status_code=stored_response.status,
headers=stored_response.headers,
stream=CacheStream(fake_stream(stored_response.content)),
extensions=stored_response.extensions,
)
raise # pragma: no cover
assert isinstance(response.stream, tp.Iterable)
Expand All @@ -170,7 +170,7 @@ def handle_request(self, request: Request) -> Response:

# Merge headers with the stale response.
full_response = self._controller.handle_validation_response(
old_response=stored_resposne, new_response=httpcore_response
old_response=stored_response, new_response=httpcore_response
)

full_response.read()
Expand Down
Loading

0 comments on commit 2e6acd8

Please sign in to comment.