Fix inner transport not closed (#147)

* Fix transport not closed

* Fix connection pool not closed

* chanelog

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Fix inner transport and connection pool instances closing. (#147)
 - Improved error message when the storage type is incorrect. (#138)
 
 ## 0.0.20 (12/12/2023)

hishel/_async/_pool.py

@@ -135,6 +135,9 @@ async def handle_async_request(self, request: Request) -> Response:
     async def aclose(self) -> None:
         await self._storage.aclose()
 
+        if hasattr(self._pool, "aclose"):  # pragma: no cover
+            await self._pool.aclose()
+
     async def __aenter__(self: T) -> T:
         return self
 

hishel/_async/_transports.py

@@ -235,6 +235,7 @@ async def handle_async_request(self, request: Request) -> Response:
 
     async def aclose(self) -> None:
         await self._storage.aclose()
+        await self._transport.aclose()
 
     async def __aenter__(self) -> "Self":
         return self

hishel/_sync/_pool.py

@@ -135,6 +135,9 @@ def handle_request(self, request: Request) -> Response:
     def close(self) -> None:
         self._storage.close()
 
+        if hasattr(self._pool, "close"):  # pragma: no cover
+            self._pool.close()
+
     def __enter__(self: T) -> T:
         return self
 

hishel/_sync/_transports.py

@@ -235,6 +235,7 @@ def handle_request(self, request: Request) -> Response:
 
     def close(self) -> None:
         self._storage.close()
+        self._transport.close()
 
     def __enter__(self) -> "Self":
         return self