-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyproject.toml #161
Conversation
Move typing_extensions dependency from requirements.txt -> pyproject.toml. Per this issue: karpetrosyan#160 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 2064 2064
=========================================
Hits 2064 2064 ☔ View full report in Codecov by Sentry. |
Thanks for this pull request 🙏 Line 32 in 6742e73
We also need to remove it from requirements.txt and add a changelog entry. |
Move typing_extensions dependency to project dependencies, from optional.
I was trying to be respectful of the nice, clean dependency list you have, but I realize adding it as an optional dependency wouldn't have helped! Thanks for the correction |
Remove typing_extensions from requirements.txt. typing_extensions is moved to pyproject.toml
Removed |
It's a manual change. I will help you. |
Thank you for your contribution 🎉 |
Add typing_extensions dependency to pyproject.toml.
Per this issue: #160 (comment)