Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml #161

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Update pyproject.toml #161

merged 4 commits into from
Jan 11, 2024

Conversation

redjax
Copy link
Contributor

@redjax redjax commented Jan 10, 2024

Add typing_extensions dependency to pyproject.toml.

Per this issue: #160 (comment)

Move typing_extensions dependency from requirements.txt -> pyproject.toml.

Per this issue: karpetrosyan#160 (comment)
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6742e73) 100.00% compared to head (f9e6e03) 100.00%.

❗ Current head f9e6e03 differs from pull request most recent head 1a11ed3. Consider uploading reports for the commit 1a11ed3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #161   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         2064      2064           
=========================================
  Hits          2064      2064           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karpetrosyan
Copy link
Owner

Thanks for this pull request 🙏
You have added it as an optional dependency, like pip install hishel[sqlite]
Instead, It should be alongside httpx

"httpx>=0.22.0"

We also need to remove it from requirements.txt and add a changelog entry.

Move typing_extensions dependency to project dependencies, from optional.
@redjax
Copy link
Contributor Author

redjax commented Jan 10, 2024

I was trying to be respectful of the nice, clean dependency list you have, but I realize adding it as an optional dependency wouldn't have helped! Thanks for the correction

Remove typing_extensions from requirements.txt. typing_extensions is moved to pyproject.toml
@redjax
Copy link
Contributor Author

redjax commented Jan 10, 2024

Removed typing_extensions from requirements.txt (missed that part in your reply to my issue). As for updating the changelog, is this done automatically, or is that a manual change?

@karpetrosyan
Copy link
Owner

karpetrosyan commented Jan 11, 2024

or is that a manual change?

It's a manual change. I will help you.

@karpetrosyan
Copy link
Owner

Thank you for your contribution 🎉

@karpetrosyan karpetrosyan merged commit 214e432 into karpetrosyan:master Jan 11, 2024
6 checks passed
@karpetrosyan karpetrosyan mentioned this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants