Changes for sending mail before the job is scheduled, as part of sanity check for users #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed email body Added html email template to the email body to display the slots information in a cleaner template. * Removed bug in creating template * Updated Readme to add new email template
Revert was done as createTemplate method iterates on a string, and throws errors. This reverts commit f04624d.
…as part of sanity check for users
harshchiki
commented
May 3, 2021
| @@ -14,7 +14,7 @@ exports.sendEmail = function (email, subjectLine, slotDetails, callback) { | |||
| from: String('Vaccine Checker ' + process.env.EMAIL), | |||
| to: email, | |||
| subject: subjectLine, | |||
| text: 'Vaccine available. Details: \n\n' + slotDetails | |||
| text: slotDetails | |||
| }; | |||
| nodemailerTransporter.sendMail(options, (error, info) => { | |||
There was a problem hiding this comment.
I hope this takes care of a misconfiguration (or anything) - and throws up if the mail could not be sent.
Assuming you are facing this issue with the changes of the PR applied. Can you confirm, if you are seeing the same on the current master branch (essentially ruling out the changes of this PR)? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: #31
@abhilashkulkarniofficial , could you please review. I have tested and sharing below the screenshot.