Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-release] add security option #708

Merged
merged 2 commits into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 34 additions & 34 deletions .github/workflows/build-latest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,40 +134,40 @@ jobs:
name: kartoza-geoserver
path: /tmp/geoserver.tar

# scan_image:
# runs-on: ubuntu-latest
# timeout-minutes: 20
# if: |
# github.actor != 'dependabot[bot]' &&
# !(
# contains(github.event.pull_request.title, '[skip-release]') ||
# contains(github.event.comment.body, '/skiprelease')
# )
# needs: [run-scenario-tests]
# steps:
# - uses: actions/checkout@v4
# - name: Download artifact
# uses: actions/download-artifact@v4
# with:
# name: kartoza-geoserver
# path: /tmp
# - name: Load image
# run: |
# docker load --input /tmp/geoserver.tar
# - name: Run Trivy vulnerability scanner
# uses: aquasecurity/trivy-action@master
# with:
# format: 'sarif'
# ignore-unfixed: true
# image-ref: kartoza/geoserver:manual-build
# output: 'trivy-results.sarif'
# severity: 'CRITICAL,HIGH'
# vuln-type: 'os,library'
#
# - name: Upload Trivy scan results to GitHub Security tab
# uses: github/codeql-action/upload-sarif@v3
# with:
# sarif_file: 'trivy-results.sarif'
scan_image:
runs-on: ubuntu-latest
timeout-minutes: 20
if: |
github.actor != 'dependabot[bot]' &&
!(
contains(github.event.pull_request.title, '[skip-release]') ||
contains(github.event.comment.body, '/skiprelease')
)
needs: [run-scenario-tests]
steps:
- uses: actions/checkout@v4
- name: Download artifact
uses: actions/download-artifact@v4
with:
name: kartoza-geoserver
path: /tmp
- name: Load image
run: |
docker load --input /tmp/geoserver.tar
- name: Run Trivy vulnerability scanner
uses: aquasecurity/trivy-action@master
with:
format: 'sarif'
ignore-unfixed: true
image-ref: kartoza/geoserver:manual-build
output: 'trivy-results.sarif'
severity: 'CRITICAL,HIGH'
vuln-type: 'os,library'

- name: Upload Trivy scan results to GitHub Security tab
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: 'trivy-results.sarif'

run-scenario-tests:
runs-on: ubuntu-latest
Expand Down
13 changes: 13 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,19 @@ to see if there are no issues reported there. We rely on the GeoServer community
issues. For urgent upstream problems, you will need to get paid support
from the developers in [GeoServer](https://geoserver.org/).

### Security Vulnerabilities
The published image uses [Trivy](https://trivy.dev/latest/) to scan vulnerabilities. These vulnerabilities
are listed in the [security section](https://github.com/kartoza/docker-geoserver/security/code-scanning).
You can also use other tools to scan the image for vulnerabilities i.e. `docker scan`.
The images also inherit vulnerabilities from the base images i.e. [tomcat:9.0.91-jdk11-temurin-focal](https://hub.docker.com/_/tomcat/tags?name=9.0.91-jdk11-temurin-focal).
So when reporting please vulnerabilities please try to distinguish them from the following:
* Base image vulnerabilities - These should be reported in the upstream tomcat repository
and if any fix is applied, we will have to build a new image using a newer image tag.
* Packages installed with these images i.e. gosu. These should be reported as an
issue in this repository and should be tagged with the `security` label.
* Vulnerabilities directly related to libs installed with the GeoServer application, these
should be reported upstream following the guidelines from [upstream geoserver](https://github.com/geoserver/geoserver/blob/main/SECURITY.md)

Other platforms where users can ask questions and get assistance are listed below:
* [Stack Exchange](https://stackexchange.com/)
* [GeoServer Mailing lists](https://sourceforge.net/projects/geoserver/lists/geoserver-users)
Expand Down