Make animated visualizations for the target area #108

[pierrealixt]

Implementation for #108 - added support for creating animations of an area.

[timlinux]

Cool thanks @pierrealixt . Can you take care of the failing tests (see https://travis-ci.org/kartoza/osm-reporter/jobs/373057299#L933) - it looks like you need to add BeautifulSoup to the requirements file.

Also, it is nice if you can make little screen animations using https://www.cockos.com/licecap/ or similar and attach to the PR so that the reviewer can easily see what the changeset does without needing to run the code themselves.

For your PR can you include a minimal description that refers back to the ticket e.g. "Implementation for #108 - added support for creating animations of an area."

For the code there are some compliance issues to our standards. Can you start by running pep8 and flake8 against the code base and making sure you have fixed any issues they identify. Then I will do a code walk through with you on wed, outlining any other style related issues I see.

Awesome stuff man!

[pierrealixt]

The reason why checks have failed has something to do with the executables I use: snap, render, encode.
It seems I must compile them on the Travis machine.

[timlinux]

RUN apt-get -y install osm2pgsql wget unzip
RUN wget -O osm-snap.zip "https://github.com/ericfischer/osm-snap/archive/master.zip" && unzip osm-snap.zip && cd osm-snap-master && make && mv snap /usr/local/bin

[timlinux]

It looks like you are committing the binaries for snap, render and encode now. Is that intended or are you going to rather build them on the fly in docker? Either is ok for me.

[timlinux]

Terminate with full stop and then add newline before extended description

Frame is an object representing a frame of the final GIF.

[timlinux]

It should not needed to repeat these here - the first line of this file already imports everything from requirements.txt

[pierrealixt]

OK but it doesnt. The first line is commented so it doesn't install what's in requirements.txt.

Am i right?

[pierrealixt]

So I uncommented the first line in requirements-dev.txt.
Then I built an image from Dockerfile.dev with the command:
docker build -f Dockerfile.dev -t "pat-osm-reporter" .

And it crashed as expected: maximum recursion depth exceeded.
Because we ADD HOST/requirements-dev.txt as CONTAINER/requirements.txt
and RUN the pip install command which will install from requirements.txt => maximum recursion depth! KABOOM.

Does it make sense?