JG 91 homework6 ruslan modify file #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rus1ko1983
changed the title
|
Hi, Please check |
kasmarian
requested changes
Dec 3, 2018
| // URL resource = ReadInBUFTest.class.getClassLoader().getResource("Text.txt"); | ||
| // System.out.println(resource); | ||
| // String fileFrom = resource.getFile(); | ||
| String fileFrom = "/home/rstepanc/IdeaProjects/java-geeks/modules/ruslan/target/classes/Test"; |
There was a problem hiding this comment.
should not be absolute path here
| writer.close(); | ||
| } | ||
|
|
||
| public static byte[] toLow(byte[] arr){ |
There was a problem hiding this comment.
should be made with regex not array of bytes
rus1ko1983
changed the title
rus1ko1983
changed the title
rus1ko1983
changed the title
kasmarian
requested changes
Dec 17, 2018
|
|
||
| BufferedWriter writer = new BufferedWriter(new FileWriter(new File(FILENAME))); | ||
| writer.append(str); | ||
| writer.close(); |
There was a problem hiding this comment.
close should always be called in finally block
|
|
||
| //given | ||
| URL resource = ReadInBUFTest.class.getClassLoader().getResource("Test"); | ||
| System.out.println(resource); |
There was a problem hiding this comment.
we don't need System.out.println(resource);
kasmarian
requested changes
Dec 20, 2018
|
|
||
| public static void WorkWithFile (File file) throws IOException { | ||
|
|
||
| BufferedReader br = new BufferedReader(new FileReader(file)); |
There was a problem hiding this comment.
use try catch with resources, or just try block, and close streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.