-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC: add client side ids to notification listeners. #2085
base: dev
Are you sure you want to change the base?
Conversation
…to-stream-messages
Codecov Report
@@ Coverage Diff @@
## dev #2085 +/- ##
==========================================
+ Coverage 59.19% 59.54% +0.34%
==========================================
Files 678 678
Lines 32831 33071 +240
==========================================
+ Hits 19434 19691 +257
+ Misses 10596 10527 -69
- Partials 2801 2853 +52
Continue to review full report at Codecov.
|
…otificationMessage`
this has been requested by devs in the discord development channel, specfically for kdx, and perhaps for usage in the vitex gateway?
it allows, for example, kaspad clients which handle multiple users, to differentiate the kaspad stream responses specific for each user.
To Do:
Register...WithId
to kaspad rpcclient, for id usage in the native client.on a further note, it can be used to perhaps create a new listener with each id requested, but may be for further development based on this pr, but beyond the scope of this pr itself.
I also hope some of the code can be used for future rpc reworks.
Note: currently I believe this only works for situations where clients intiate a seperate rpc connection, for each notification stream.