Remove kaspa prefix from NetworkId, refactor and stabilize JavaScript examples. Introduce wasm::Network type for WASM bindings.
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkId implementation
…out arguments (via Option).
michaelsutton
approved these changes
Aug 29, 2023
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
…pt examples. Introduce `wasm::Network` type for WASM bindings. (kaspanet#251) * unify NetworkId implementations, remove prefix from the default NetworkId implementation * modify params to return NetworkId::to_prefixed() * propagate wasm::Network through WASM APIs * fix derivation path JsValue conversion; allow Mnemonic::toSeed() without arguments (via Option). * Refactor and stabilize JavaScript examples using the new Network type * fix unit tests & simplify creation in Args * use prefixed names for log/db sub-folders --------- Co-authored-by: Michael Sutton <[email protected]> Co-authored-by: Michael Sutton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a general PR that overhauls
NetworkIdtype removingkaspaprefix and refactoring / stabilizing related JavaScript examples.This PR introduces the following changes:
kapsaprefix from theNetworkIdand introducesNetworkId::from_prefixed()andNetworkId::to_prefixed(). The prefix is retained within gRPC protowire conversions, and in parameters needed for p2p comms. The prefix is currently removed from folder names (can be resurrected during the review).kaspa_consensus_core::network_typeis renamed tokaspa_consensus_core::networkas it containsNetworkTypeandNetworkIdNetworktype is introduced inside of thenetwork::wasmmodule:kaspa_consensus_core::network::wasm::Network. This type is specific to WASM bindings allowing functions to receive either aNetworkTypeorNetworkId(it effectively allows passingNetworkIdwhereNetworkTypeis required).It contains the following TypeScript signature:
NetworkType | NetworkId | string.This simplifies the usage of network ids/types within the JavaScript SDK.
Mnemonic::toSeed()has been changed to not require a passwordnodejs/refactoring/tonodejs/(namelymnemonicandderivation)