Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --send-all option #584

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

x100111010
Copy link

  • fix formatting and typos (and refactored text in docs/testnet11.md) 667ffb3

  • added --send-all option to send command, allowing users to send their entire mature balance minus an optional priority fee
  • retains feature parity between Go and Rust implementations (the Go wallet has --send-all) 07fd91b

* added `--send-all` option to `send` command, allowing users to send their entire mature balance minus an optional priority fee
* retains feature parity between Go and Rust implementations (the Go node has `--send-all`)
@KaffinPX
Copy link
Contributor

maybe a MAX special value instead of a param? @aspect

@coderofstuff
Copy link
Collaborator

@KaffinPX this being --send-all is probably to match what it used to be in the kaspad go wallet: https://github.com/kaspanet/kaspad/blob/6085d1fc84d71f74a571fad2b7e5b38413a3db5a/cmd/kaspawallet/config.go#L67

@x100111010
Copy link
Author

@KaffinPX this being --send-all is probably to match what it used to be in the kaspad go wallet: https://github.com/kaspanet/kaspad/blob/6085d1fc84d71f74a571fad2b7e5b38413a3db5a/cmd/kaspawallet/config.go#L67

Yes exactly! It was a missing feature in the rust wallet so I submitted this PR to maintain feature parity.

* added `\n` newline for some space between displayed txids
* useful and important for `--send-all`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants