Merge pull request #150 from katalon-studio/TES-5093

[TES-5093] Use apikey of job, config organizationId instead of teamId
katalon-studio · Nov 28, 2023 · 22eee52 · 22eee52
2 parents d318d7b + 9019050
commit 22eee52
Show file tree

Hide file tree

Showing 10 changed files with 96 additions and 81 deletions.
diff --git a/cli.js b/cli.js
@@ -26,7 +26,7 @@ program
   .option('-s, --server-url <value>', 'Katalon Analytics URL')
   .option('-u, --username <value>', 'Email')
   .option('-p, --apikey <value>', 'API key')
-  .option('-t, --teamid <value>', 'Team ID')
+  .option('-t, --organizationid <value>', 'Organization ID')
   .option('-a, --agent-name <value>', 'Agent name')
   .option('-c, --config <value>', 'Configuration file path')
   .option('-x, --proxy <value>', 'HTTTP/HTTPS Proxy')
@@ -40,7 +40,7 @@ program
       serverUrl: command.serverUrl,
       email: command.username,
       apikey: command.apikey,
-      teamId: command.teamid,
+      organizationId: command.organizationid,
       agentName: command.agentName,
       configPath: command.config,
       proxy: command.proxy,
@@ -58,7 +58,7 @@ program
   .option('-s, --server-url <value>', 'Katalon Analytics URL')
   .option('-u, --username <value>', 'Email')
   .option('-p, --apikey <value>', 'API key')
-  .option('-t, --teamid <value>', 'Team ID')
+  .option('-t, --organizationid <value>', 'Organization ID')
   .option('-a, --agent-name <value>', 'Agent name')
   .option('-c, --config <value>', 'Configuration file path')
   .option('-x, --proxy <value>', 'HTTTP/HTTPS Proxy')
@@ -68,7 +68,7 @@ program
       serverUrl: command.serverUrl,
       email: command.username,
       apikey: command.apikey,
-      teamId: command.teamid,
+      teamId: command.organizationid,
       agentName: command.agentName,
       configPath: command.config,
       proxy: command.proxy,

diff --git a/src/core/api/api.js b/src/core/api/api.js
@@ -4,6 +4,13 @@ const http = require('./http');
 const httpInternal = require('./http-testops');
 const urlParam = require('./url-param');
 const { getBasicAuthHeader } = require('./utils');
+const { getAuth } = require('../auth');
+
+function withAuthorization(apiKey) {
+  return {
+    Authorization: getBasicAuthHeader(getAuth(apiKey)),
+  };
+}
 
 module.exports = {
   requestToken(email, password) {
@@ -29,8 +36,8 @@ module.exports = {
     return httpInternal.post(urlParam.accessToken(), data);
   },
 
-  getUploadInfo(projectId) {
-    return httpInternal.get(urlParam.getUploadInfo(projectId));
+  getUploadInfo(projectId, apiKey) {
+    return httpInternal.get(urlParam.getUploadInfo(projectId), withAuthorization(apiKey));
   },
 
   uploadFile(uploadUrl, filePath) {
@@ -45,6 +52,7 @@ module.exports = {
     uploadedPath,
     isEnd,
     reportType,
+    apiKey,
     extraParams = {},
   ) {
     return httpInternal.post(
@@ -58,43 +66,45 @@ module.exports = {
         reportType,
         extraParams,
       ),
+      null,
+      this.withAuthorization(apiKey),
     );
   },
 
   pingAgent(body) {
     return httpInternal.post(urlParam.pingAgent(), body);
   },
 
-  pingJob(jobId) {
-    return httpInternal.patch(urlParam.pingJob(jobId));
+  pingJob(jobId, apiKey) {
+    return httpInternal.patch(urlParam.pingJob(jobId), null, withAuthorization(apiKey));
   },
 
-  requestJob(uuid, teamId) {
-    return httpInternal.get(urlParam.requestJob(uuid, teamId));
+  requestJob(uuid, organizationId) {
+    return httpInternal.get(urlParam.requestJob(uuid, organizationId));
   },
 
-  updateJob(body) {
-    return httpInternal.post(urlParam.updateJob(), body);
+  updateJob(body, apiKey) {
+    return httpInternal.post(urlParam.updateJob(), body, withAuthorization(apiKey));
   },
 
-  saveJobLog(jobInfo, batch, fileName) {
-    return httpInternal.post(urlParam.saveJobLog(jobInfo, batch, fileName));
+  saveJobLog(jobInfo, batch, fileName, apiKey) {
+    return httpInternal.post(urlParam.saveJobLog(jobInfo, batch, fileName), null, withAuthorization(apiKey));
   },
 
-  notifyJob(jobId, projectId) {
-    return httpInternal.post(urlParam.notifyJob(jobId, projectId));
+  notifyJob(jobId, projectId, apiKey) {
+    return httpInternal.post(urlParam.notifyJob(jobId, projectId), null, withAuthorization(apiKey));
   },
 
   getBuildInfo() {
     return httpInternal.get(urlParam.getBuildInfo());
   },
 
-  updateNodeStatus(jobId, nodeStatus) {
+  updateNodeStatus(jobId, nodeStatus, apiKey) {
     const data = {
       id: jobId,
       nodeStatus,
     };
-    return httpInternal.put(urlParam.updateNodeStatus(), data);
+    return httpInternal.put(urlParam.updateNodeStatus(), data, withAuthorization(apiKey));
   },
 
   getKSReleases() {
@@ -105,7 +115,7 @@ module.exports = {
     return http.stream(urlParam.download(url), filePath);
   },
 
-  downloadFromTestOps(url, filePath) {
-    return httpInternal.stream(urlParam.download(url), filePath);
+  downloadFromTestOps(url, filePath, apiKey) {
+    return httpInternal.stream(urlParam.download(url), filePath, withAuthorization(apiKey));
   },
 };
diff --git a/src/core/api/http-testops.js b/src/core/api/http-testops.js
@@ -4,7 +4,7 @@ const { getBasicAuthHeader } = require('./utils');
 
 function withAuthorization(current = {}) {
   return {
-    Authorization: getBasicAuthHeader(getAuth()),
+    Authorization: (current && current.Authorization) ? current.Authorization : getBasicAuthHeader(getAuth()),
     ...current,
   };
 }

diff --git a/src/core/api/url-param.js b/src/core/api/url-param.js
@@ -53,10 +53,10 @@ module.exports = {
     return buildUrl({}, PATHS.JOB, jobId);
   },
 
-  requestJob(uuid, teamId) {
+  requestJob(uuid, organizationId) {
     const params = {
       uuid,
-      teamId,
+      organizationId,
     };
     return buildUrl({ params }, PATHS.JOB, 'get-job');
   },

diff --git a/src/core/auth.js b/src/core/auth.js
@@ -1,9 +1,9 @@
 const config = require('./config');
 
-function getAuth() {
+function getAuth(apikey) {
   return {
     username: '',
-    password: config.apikey,
+    password: apikey || config.apikey,
   };
 }
 

diff --git a/src/core/file.js b/src/core/file.js
@@ -7,7 +7,7 @@ const fs = require('fs-extra');
 const api = require('./api');
 const defaultLogger = require('../config/logger');
 
-function download(downloadMethod, url, logger = defaultLogger) {
+function download(downloadMethod, url, logger = defaultLogger, apiKey) {
   logger.info(`Downloading from ${url}. It may take a few minutes.`);
   const file = tmp.fileSync();
   const filePath = file.name;
@@ -19,7 +19,7 @@ function download(downloadMethod, url, logger = defaultLogger) {
     }
     return Promise.reject(new Error(`Unable to download from ${url} to ${filePath}`));
   };
-  return downloadMethod(url, filePath)
+  return downloadMethod(url, filePath, apiKey)
     .then(verifyDownloadedFile);
 }
 
@@ -57,8 +57,8 @@ module.exports = {
     );
   },
 
-  downloadFromTestOps(url, targetPath, logger = defaultLogger) {
-    return download(api.downloadFromTestOps, url, logger).then((filePath) =>
+  downloadFromTestOps(url, targetPath, apiKey, logger = defaultLogger) {
+    return download(api.downloadFromTestOps, url, logger, apiKey).then((filePath) =>
       this.move(filePath, targetPath, logger),
     );
   },

diff --git a/src/helper/agent.js b/src/helper/agent.js
@@ -24,7 +24,6 @@ function buildUpdateJobBody(jobId, jobStatus, processId) {
 
 function createCommandExecutor(
   projectId,
-  teamId,
   ksArgs,
   x11Display,
   xvfbConfiguration,
@@ -42,7 +41,7 @@ function createCommandExecutor(
   }
 
   const info = {
-    teamId,
+    teamId: parameter.teamId,
     projectId,
     ksVersionNumber: parameter.ksVersion,
     ksLocation: parameter.ksLocation,