[TES-417] The session log could not be pushed to TestOps #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HieuNguyenMinh-katalon
requested review from
tuananht,
quidl,
lydoan1199,
hiepvuhoang and
TuanNguyen-Dev14
HieuNguyenMinh-katalon
changed the title
lydoan1199
suggested changes
Jan 3, 2024
src/config/transports.js
Outdated
| const fileName = path.basename(this.filePath); | ||
| return api.saveJobLog(this.jobInfo, batch, fileName, this.apiKey); | ||
| }; | ||
| requestGetUploadInfo(); |
There was a problem hiding this comment.
Do we need 'await' here?
There was a problem hiding this comment.
Added await for requestGetUploadInfo(); Thank you.
|
lydoan1199
approved these changes
Jan 3, 2024
quidl
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.