Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

[TES-6303] Update Test Run List table column and decorators #37

Merged
merged 9 commits into from
Apr 24, 2024

Conversation

triquanminh
Copy link

@triquanminh triquanminh commented Apr 23, 2024

NOTE: ONLY REVIEW FILES THAT ARE NEW OR MODIFIED

  • The files changed includes code refactor by removing unused files
  • Ignore files that are deleted

Todo Decorators

  • Status: stage & status logic
  • ID: clickable link?
  • Name
  • Profile: add commas and +n?
  • Duration
  • Environment: tooltip when hover on +n
  • Time Started
  • Test Run Status
  • Configuration: clickable link?
  • Executor

@triquanminh triquanminh changed the title [WIP][TES-6303] Update Test Run List table column and decorators [TES-6303] Update Test Run List table column and decorators Apr 24, 2024
minWidth: 80,
flex: 0.7,
headerClassName: classes.tableHeader,
renderCell: cell => IDDecorator(cell.value),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idDecorator

);
};

const IDDecorator = (id: string) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idDecorator

return (
<div style={{ display: 'flex', alignItems: 'center', height: '100%' }}>
<div style={{ marginRight: '4px' }}>
<Icon src="/static/assets/images/katalon/profile.svg" size="16px" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move icons to common components.

Comment on lines +172 to +173
let decoratedDuration = moment.utc(milliseconds).format('HH[h] mm[m] ss[s]');
decoratedDuration = decoratedDuration.replace(/00[hms]/g, '').trim();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to helper

const columns: GridColDef[] = [
{
field: 'status',
headerName: 'STATUS',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n


const rows = formatData(data);

const columns: GridColDef[] = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revamp to support decorators based on specific dataset.

@huynguyen2908 huynguyen2908 merged commit 0056697 into 3.1.0.katalon Apr 24, 2024
38 of 58 checks passed
@huynguyen2908 huynguyen2908 deleted the TES-6303 branch April 24, 2024 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants