Add profile link for Koi navigation header #583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hasarindaKI
commented
Mar 7, 2024
hasarindaKI
commented
hasarindaKI
force-pushed
the
feature/admin-profile
branch
4 times, most recently
from
7f41ee8
to
52918a5
Compare
hasarindaKI
force-pushed
the
feature/admin-profile
branch
from
52918a5
to
171f0c0
Compare
sfnelson
reviewed
Mar 8, 2024
| @@ -1,6 +1,10 @@ | |||
| <header> | |||
| <h2 class="site-name"><%= URI.parse(root_url).host %></h2> | |||
| <h3 class="admin-name">Koi Admin</h3> | |||
| <% if local_assigns[:admin].present? %> | |||
There was a problem hiding this comment.
There won't be a situation where there is no admin we require an admin to see this view.
This isn't the same as the design we discussed. Why did you decide to go with this approach rather than a footer for the nav bar? There's also no logout link here or profile picture.
sfnelson
force-pushed
the
feature/admin-profile
branch
from
171f0c0
to
a18f897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.