handle PR files pages

cli/gh-pr-filters.go

@@ -89,14 +89,15 @@ func GetFilterForMilestone(milestoneRaw string) *Filter {
 		PR: func(pr github.PullRequest) (bool, error) {
 			milestone := pr.GetMilestone().GetTitle()
 
-			// nolint:gocritic
+			//nolint:gocritic
 			if strings.EqualFold(filterMilestone, milestone) && !negate {
 				c.Printf("    milestone: <green>%s</> <gray>(%s)</>\n", filterMilestone, milestone)
 				return true, nil
 			} else if negate {
 				c.Printf("    milestone: <green>-%s</> <gray>(%s)</>\n", filterMilestone, milestone)
 				return true, nil
 			} else {
+				//revive:disable:indent-error-flow
 				c.Printf("    milestone: <red>%s</> <gray>(%s)</>\n", filterMilestone, milestone)
 				return false, nil
 			}
@@ -207,7 +208,7 @@ func GetFilterForLabels(labels []string, and bool) *Filter {
 			for filterLabel, negate := range filterLabelMap {
 				_, found := labelMap[filterLabel]
 
-				// nolint:gocritic
+				//nolint:gocritic
 				if found && !negate {
 					orPass = true
 					c.Printf(" <green>%s</>", filterLabel)

cli/gh-pr.go

@@ -43,7 +43,7 @@ func (f FlagData) GetPrTests(pr int) (*map[string][]string, error) {
 }
 
 // todo break this apart - get/check PR state, get files, filter/process files, get tests, get services.
-func (gr githubRepo) PrTests(pri int, filterRegExStr, splitTestsAt string) (*map[string][]string, error) {
+func (gr GithubRepo) PrTests(pri int, filterRegExStr, splitTestsAt string) (*map[string][]string, error) {
 	client, ctx := gr.NewClient()
 	httpClient := chttp.NewHTTPClient("HTTP")
 
@@ -94,7 +94,7 @@ func (gr githubRepo) PrTests(pri int, filterRegExStr, splitTestsAt string) (*map
 		}
 
 		// todo thread ctx
-		// nolint: noctx
+		//nolint: noctx
 		resp, err := httpClient.Get(*fileContents.DownloadURL)
 		if err != nil {
 			return nil, fmt.Errorf("downloading file (%s): %w", f, err)
@@ -151,7 +151,7 @@ func (gr githubRepo) PrTests(pri int, filterRegExStr, splitTestsAt string) (*map
 	return &serviceTests, nil
 }
 
-func (gr githubRepo) ListAllPullRequestFiles(pri int, cb func([]*github.CommitFile, *github.Response) error) error {
+func (gr GithubRepo) ListAllPullRequestFiles(pri int, cb func([]*github.CommitFile, *github.Response) error) error {
 	client, ctx := gr.NewClient()
 
 	opts := &github.ListOptions{
@@ -179,7 +179,7 @@ func (gr githubRepo) ListAllPullRequestFiles(pri int, cb func([]*github.CommitFi
 	return nil
 }
 
-func (gr githubRepo) GetAllPullRequestFiles(pri int, filterRegExStr string) (*map[string]struct{}, error) {
+func (gr GithubRepo) GetAllPullRequestFiles(pri int, filterRegExStr string) (*map[string]struct{}, error) {
 	result := make(map[string]struct{})
 	filterRegEx := regexp.MustCompile(filterRegExStr)
 
@@ -218,7 +218,6 @@ func (gr githubRepo) GetAllPullRequestFiles(pri int, filterRegExStr string) (*ma
 
 		return nil
 	})
-
 	if err != nil {
 		return nil, fmt.Errorf("failed to get all files for %s/%s/pull/%d: %w", gr.Owner, gr.Name, pri, err)
 	}

cli/gh.go

@@ -8,11 +8,11 @@ import (
 )
 
 // wrap the common gh lib shared with my other tools. splits common GH code from this CLI tool's specific tooling code
-type githubRepo struct {
+type GithubRepo struct {
 	gh.Repo
 }
 
-func (f FlagData) NewRepo() githubRepo {
+func (f FlagData) NewRepo() GithubRepo {
 	ownerrepo := f.GH.Repo
 
 	parts := strings.Split(ownerrepo, "/")
@@ -24,5 +24,5 @@ func (f FlagData) NewRepo() githubRepo {
 	token := f.GH.Token
 	clog.Log.Debugf("new gh: %s@%s/%s", token, owner, repo)
 
-	return githubRepo{gh.NewRepo(owner, repo, token)}
+	return GithubRepo{gh.NewRepo(owner, repo, token)}
 }

cli/tc.go

@@ -5,10 +5,10 @@ import (
 )
 
 // wrap the common gh lib shared with my other tools. splits common GH code from this CLI tool's specific tooling code
-type tcServer struct {
+type TcServer struct {
 	tc.Server
 }
 
-func (f FlagData) NewServer() tcServer {
-	return tcServer{tc.NewServer(f.TC.ServerURL, f.TC.Token, f.TC.User, f.TC.Pass)}
+func (f FlagData) NewServer() TcServer {
+	return TcServer{tc.NewServer(f.TC.ServerURL, f.TC.Token, f.TC.User, f.TC.Pass)}
 }

lib/chttp/http.go

@@ -18,12 +18,12 @@ func NewHTTPClient(name string) *http.Client {
 	}
 }
 
-type transport struct {
+type Transport struct {
 	name      string
 	transport http.RoundTripper
 }
 
-func (t *transport) RoundTrip(req *http.Request) (*http.Response, error) {
+func (t *Transport) RoundTrip(req *http.Request) (*http.Response, error) {
 	reqData, err := httputil.DumpRequestOut(req, true)
 
 	if err == nil {
@@ -47,8 +47,8 @@ func (t *transport) RoundTrip(req *http.Request) (*http.Response, error) {
 	return resp, nil
 }
 
-func NewTransport(name string, t http.RoundTripper) *transport {
-	return &transport{name, t}
+func NewTransport(name string, t http.RoundTripper) *Transport {
+	return &Transport{name, t}
 }
 
 // prettyPrintJSON iterates through a []byte line-by-line,
@@ -58,7 +58,7 @@ func prettyPrintJSON(b []byte) string {
 	for i, p := range parts {
 		if b := []byte(p); json.Valid(b) {
 			var out bytes.Buffer
-			// nolint:errcheck
+			//nolint:errcheck
 			json.Indent(&out, b, "", " ")
 			parts[i] = out.String()
 		}