Solution 2.2 Added #35
Conversation
| if (start_byte == 0 and end_byte == 0): | ||
| byte_range = "" | ||
| else: | ||
| byte_range = "Range: bytes=%s-%s\r\n" %(str(start_byte), str(end_byte)) |
There was a problem hiding this comment.
Space after %. Also violates line length limit.
| else: | ||
| byte_range = "Range: bytes=%s-%s\r\n" %(str(start_byte), str(end_byte)) | ||
| header = "%s %s HTTP/1.1\r\nHost: %s\r\n" %(req_type, path, host) | ||
| header += (byte_range + "\r\n") |
There was a problem hiding this comment.
I would suggest creating a dictionary<header-key, header-value> and using that instead. Building a raw string like this is inelegant.
| @@ -0,0 +1,162 @@ | |||
| import argparse | |||
| import urlparse | |||
There was a problem hiding this comment.
Cant use this module. Use re instead.
| "GET", | ||
| self.start_byte, | ||
| self.end_byte | ||
| ) |
There was a problem hiding this comment.
This is strange. Prefer:
data_request = request(
self.path,
...
)
| import os | ||
|
|
||
|
|
||
| def request(path, host, req_type, start_byte, end_byte): |
There was a problem hiding this comment.
This name is inaccurate. "get_headers" is more correct, since you're not actually making any requests.
| thread_num+=1 | ||
| self.threads.append(thread) | ||
| for thread in self.threads: | ||
| thread.start() |
There was a problem hiding this comment.
Why not start in the previous loop?
| outfile = os.path.basename(os.path.basename(self.path)) | ||
| output_file = open(outfile, 'w') | ||
| logging.info("Writing To File ...") | ||
| s = "" |
| logging.info("Writing To File ...") | ||
| s = "" | ||
| for num in range(thread_num): | ||
| filename = 'tempfile'+str(num) |
There was a problem hiding this comment.
Didn't you import the tempfile module? Why not use that?
| response_data = response_data[first_index + 16 : ] | ||
| last_index = response_data.find("\r\n") | ||
| response_data = response_data[ : last_index] | ||
| response_data.strip() |
There was a problem hiding this comment.
The last few lines look very fragile.
| logging.info("Download Completed Successfully !!!") | ||
|
|
||
|
|
||
| if __name__ == '__main__' : |
There was a problem hiding this comment.
Put this in a separate file. In order to make your code reuseable, you need to separate core logic from CLI, so that someone can use the download, without having to deal with overhead of CLI.
Please Review @kaustubh-karkare