Fix workspace container tests #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests pass locally but consistently fail on Github Actions. * Downgraded ubuntu runner / kernel * Made the tests themselves ensure that the services are available rather than checking a possibly fragile log line. Also moved them to a test directory rather than scripts. Also also slightly modified the Docker file so slow steps are cached before copying in code, which busts the cache.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #721 +/- ##
==========================================
Coverage 87.66% 87.66%
Complexity 5329 5329
==========================================
Files 228 228
Lines 17648 17648
Branches 2573 2573
==========================================
Hits 15471 15471
Misses 1714 1714
Partials 463 463 |
ialarmedalien
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests pass locally but consistently fail on Github Actions.
Also moved them to a test directory rather than scripts.
Also also slightly modified the Docker file so slow steps are cached before copying in code, which busts the cache.