Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/persist fta diagram layout #140

Merged
merged 9 commits into from
Jan 16, 2024
Merged

Conversation

kostobog
Copy link
Collaborator

@kostobog kostobog commented Jan 5, 2024

Partially implements #131.
Server side related changes:

… in FTA diagram

- listens for release after node drag
- call faultEventService.updateEventRectangle if position and size of node are different from rectangle
…tring 'custom/faultEventIri' when setting and getting IRI of fault event from jointjs element model.
…tion if present, use automated layout otherwise
@kostobog kostobog requested a review from blcham January 9, 2024 10:07
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments about @ts-ignore

src/components/editor/faultTree/Editor.tsx Outdated Show resolved Hide resolved
@blcham
Copy link
Contributor

blcham commented Jan 12, 2024

@kostobog

- remove @ts-ignore comments which did not cause compilation error,
- reduce @ts-ignore comments in system and fault tree Editors. Encapsulate @ts-ignore comments getter methods and refactor @ts-ignore comment lines to use the getters
@kostobog kostobog merged commit 4e1b4a7 into main Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants