Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/modified and created date #303

Merged
merged 2 commits into from
May 19, 2024
Merged

Fix/modified and created date #303

merged 2 commits into from
May 19, 2024

Conversation

Kasmadei
Copy link
Collaborator

@Kasmadei Kasmadei commented May 18, 2024 •
edited
Loading

Resolves: #247

  • Resolved and removed weird type: 
    modified?: {
  ["@value"]?: string;
};
  • Added "Created" column with translation
  • Removed "Status" column as unused (no data for it)

@Kasmadei Kasmadei requested a review from blcham May 18, 2024 12:49
@blcham blcham requested a review from LaChope May 18, 2024 13:32
blcham
blcham approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blcham
Copy link
Contributor

blcham commented May 18, 2024

@Kasmadei please sync, rebase and merge

@blcham blcham removed the request for review from LaChope May 18, 2024 13:33
@blcham blcham force-pushed the fix/modified-and-created-date branch from aacf922 to 34aa334 Compare May 19, 2024 17:40
blcham
blcham approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blcham blcham merged commit c6aa862 into kbss-cvut:main May 19, 2024
1 check passed
@blcham blcham deleted the fix/modified-and-created-date branch May 19, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement list view for FTA trees and Systems
2 participants
@Kasmadei @blcham