Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade/upgrade to java 17 #48

Merged
merged 8 commits into from
Jan 3, 2024
Merged

Upgrade/upgrade to java 17 #48

merged 8 commits into from
Jan 3, 2024

Conversation

kostobog
Copy link
Collaborator

@kostobog kostobog commented Jan 2, 2024

Fix #49
Upgrade includes:

  • java 17
    • refactor javax packages to jakatra packages
  • upgrade jopa to 1.1.4
  • springboot 3.1.5
    • refactor deprecated security
  • lombok 1.18.30

@kostobog kostobog requested a review from blcham January 2, 2024 12:06
@blcham blcham requested a review from chekaval January 2, 2024 14:08
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.authorizeHttpRequests(auth -> auth
.requestMatchers(AntPathRequestMatcher.antMatcher("/auth/register")).permitAll()
.requestMatchers(AntPathRequestMatcher.antMatcher("/auth/signin")).permitAll()
.anyRequest().authenticated())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be something like authenticationManager(buildAuthenticationManager(http)). But, my changes in the PR affect this anyway, so it doesn't really matter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For it works without callingauthenticationManager(buildAuthenticationManager(http)) on the filter chain. It seams that the authentication provider bean is automatically set up in the filter chain.

Also, I removed the line with the unused authManager variable :
final AuthenticationManager authManager = buildAuthenticationManager(http);

@chekaval
Copy link

chekaval commented Jan 2, 2024

There are no further suggestions from my side neither. I am not sure how the repository is set up (whether my approval will lead to auto-merge into master branch), so I leave it as it is.

@blcham blcham merged commit b475828 into main Jan 3, 2024
1 check passed
@blcham blcham deleted the upgrade/upgrade-to-java-17 branch January 3, 2024 16:30
@kostobog
Copy link
Collaborator Author

kostobog commented Jan 4, 2024

Commit eb91ec1 fixes Use Springboot in the Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to jopa 1.1.4
3 participants