-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade/upgrade to java 17 #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/main/java/cz/cvut/kbss/analysis/persistence/MainPersistenceFactory.java
Outdated
Show resolved
Hide resolved
.authorizeHttpRequests(auth -> auth | ||
.requestMatchers(AntPathRequestMatcher.antMatcher("/auth/register")).permitAll() | ||
.requestMatchers(AntPathRequestMatcher.antMatcher("/auth/signin")).permitAll() | ||
.anyRequest().authenticated()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be something like authenticationManager(buildAuthenticationManager(http))
. But, my changes in the PR affect this anyway, so it doesn't really matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For it works without callingauthenticationManager(buildAuthenticationManager(http))
on the filter chain. It seams that the authentication provider bean is automatically set up in the filter chain.
Also, I removed the line with the unused authManager
variable :
final AuthenticationManager authManager = buildAuthenticationManager(http);
There are no further suggestions from my side neither. I am not sure how the repository is set up (whether my approval will lead to auto-merge into master branch), so I leave it as it is. |
Commit eb91ec1 fixes Use Springboot in the Dockerfile |
Fix #49
Upgrade includes: