Fix intl #152
Closed
Fix intl #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit cd4b4f6)
LaChope
commented
Apr 22, 2024
| enableForwardSkip={true} | ||
| loader={<Loader />} | ||
| /> | ||
| <IntlContextProvider locale={options.intl.locale}> |
There was a problem hiding this comment.
As mentioned in kbss-cvut/s-forms#193, there are 2 ways of providing intl in SForms now, which should be refactored.
|
we wait to finish it systematically |
Relates to kbss-cvut/s-forms#340 |
|
@LaChope this can be closed without merge right ? So what needs to be done to incorporate kbss-cvut/s-forms#340 ? |
|
@blcham this can be closed because of kbss-cvut/s-forms#340. When kbss-cvut/s-forms#340 is merged, I will bump s-forms in record-manager-ui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #150