-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fine grained access #208
base: main
Are you sure you want to change the base?
fine grained access #208
Conversation
7b2e15d
to
c94b109
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments + tests are failing
ecd0d6d
to
4be2f47
Compare
@blcham The admin can choose the roles for users if he have role EDIT_USER. The group input currently does not function because we need to discuss how it should be implemented. It might be better to disable the Roles input and assign roles based on the chosen group. The next point for discussion is how Keycloak will retrieve information about roles. Currently, Keycloak only gets information about roles for the current user, which makes it impossible to display accurate information about other users. I think it would be beneficial to configure the Keycloak plugin to also save this information. |
4be2f47
to
62d2b09
Compare
we do not want to assign roles, but role groups !! --- as we discussed we want to keep label "role" in RM-UI but assign there ONE role group ... but as i said if it is not changeable or even not visible there i fo not care that much -- it is not that important, we have keycloak for that. |
@blcham In Keycloak authorization, I recommend not displaying the group role, as doing so would require storing it in a triple (via the plugin change). So we will have these group roles if undestand correctly: [OPERATOR_ADMIN]
[OPERATOR_USER]
[SUPPLIER_ADMIN]
[SUPPIER]
[NON-ANONYMOUS QUESTIONARE]
|
7e5bb61
to
a8624e2
Compare
6b23dc1
to
5050dec
Compare
0a9b093
to
26f1cdc
Compare
@palagdan I rebased this PR |
26f1cdc
to
3e4992c
Compare
4351437
to
9b15576
Compare
@palagdan could you describe what the issue is and in which profile (I've lost it somehow :( |
9b15576
to
ff5b232
Compare
ff5b232
to
faad1e2
Compare
faad1e2
to
a2fa5c5
Compare
a2fa5c5
to
a8e3047
Compare
a8e3047
to
c683ca9
Compare
I fixed the issue in the Keycloak profile, so it now works as expected. You can check both the internal and Keycloak profiles. First step:
|
Resolves partially #202
Resolves partially #158