Refactor code to use the common messaging component #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent. Also refactor the statistics to a simple hooks-based functional component.
Also refactor the Institutions.js to a simple hooks-based functional component.
Also fix messaging component style (before it is removed) broken by adding the new messaging component styles.
Also provide common async action error message display.
Also extract the form loading request into an action.
blcham
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
LGTM, nice cleanup of the code! Can be merged but,
consider two things to fix:
- slice(0, ?) as mentioned in comment
- I believe you removed all tests testing for alert messages within components. Isn't it useful to know for a component that it triggers alert messages correctly? Or it would be difficult to test now after refactoring ?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #66.
The alert messages on public routes (login, password reset, password token) are kept as is, because the common messaging component is available only in the MainView, which requires authentication.