Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#71 Record filtering, paging, sorting #82

Conversation

ledsoft
Copy link

@ledsoft ledsoft commented Feb 8, 2024

Resolves #71.

Some additional notes:

  • The filters are displayed in a popover, because they would not fit in the table cells. Different visualizations are up for discussion (e.g., a line of filters above the table).
  • Export now respects the filters, so only records matching the filters are exported.
  • I did some additional refactoring (mainly giving buttons a common min width) that was not part of this ticket. Sorry.

@ledsoft ledsoft requested a review from blcham February 8, 2024 15:49
@blcham
Copy link

blcham commented Feb 9, 2024

Depending on how hard it is to implement (let's discuss), I suggest the following improvements:

  1. Change "Disabled filtering" icon as it looks strange:
    image

  2. Put filter also to headers similar way as it is done in google sheets:
    image

  3. It would be nice to know how many records there are in total

  4. It is strange to scroll within the browser and then use paging of records. Thus, it would be nice if the page of records fits exactly on the page of the browser, so the user would not need to scroll to find the button for the next page. The alternative is to have: a) infinite scrolling without paging; b) a configurable page size.

@ledsoft
Copy link
Author

ledsoft commented Feb 14, 2024

@blcham Updated the PR according to your feedback.

Copy link

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works and looks very nice

@blcham blcham merged commit ea72bbf into kbss-cvut:main Feb 16, 2024
1 of 2 checks passed
@ledsoft ledsoft deleted the kbss-cvut/record-manager-ui#71-record-filtering-paging-sorting branch February 16, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sorting/filtering/paginating of records based on AVA scenarios
2 participants