[Fix partially kbss-cvut/record-manager-ui#36] Refactor handling of i…

…nstitution request parameter. - remove unnecessary annotations from method parameters
kbss-cvut · Jul 10, 2024 · 0b985cd · 0b985cd
1 parent 1918810
commit 0b985cd
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/main/java/cz/cvut/kbss/study/rest/PatientRecordController.java b/src/main/java/cz/cvut/kbss/study/rest/PatientRecordController.java
@@ -76,14 +76,13 @@ public ResponseEntity<?> exportRecords(
 
         return switch (exportType.toString()){
             case Constants.MEDIA_TYPE_EXCEL ->  exportRecordsExcel(params, response);
-            case MediaType.APPLICATION_JSON_VALUE -> exportRecordsAsJson(institutionKey, params, uriBuilder, response);
+            case MediaType.APPLICATION_JSON_VALUE -> exportRecordsAsJson(params, uriBuilder, response);
             default -> throw new IllegalArgumentException("Unsupported export type: " + exportType);
         };
     }
 
     protected ResponseEntity<List<PatientRecord>> exportRecordsAsJson(
-            @RequestParam(name = "institution", required = false) String institutionKey,
-            @RequestParam MultiValueMap<String, String> params,
+            MultiValueMap<String, String> params,
             UriComponentsBuilder uriBuilder, HttpServletResponse response){
         final Page<PatientRecord> result = recordService.findAllFull(RecordFilterMapper.constructRecordFilter(params),
                 RestUtils.resolvePaging(params));
@@ -93,7 +92,7 @@ protected ResponseEntity<List<PatientRecord>> exportRecordsAsJson(
                 .body(result.getContent());
     }
 
-    public ResponseEntity<InputStreamResource> exportRecordsExcel(@RequestParam(required = false) MultiValueMap<String, String> params, HttpServletResponse response){
+    public ResponseEntity<InputStreamResource> exportRecordsExcel(MultiValueMap<String, String> params, HttpServletResponse response){
         RecordFilterParams filterParams = new RecordFilterParams();
         filterParams.setMinModifiedDate(null);
         filterParams.setMaxModifiedDate(null);
@@ -105,7 +104,6 @@ public ResponseEntity<InputStreamResource> exportRecordsExcel(@RequestParam(requ
                 .contentType(MediaType.parseMediaType(Constants.MEDIA_TYPE_EXCEL))
                 .header(HttpHeaders.CONTENT_DISPOSITION, contentDisposition.toString())
                 .body(new InputStreamResource(stream));
-
     }
 
     @PreAuthorize("hasRole('" + SecurityConstants.ROLE_ADMIN + "') or @securityUtils.isRecordInUsersInstitution(#key)")