forked from blcham/record-manager
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues/33 admin setting user institution in keycloack deployment #34
Closed
kostobog
wants to merge
11
commits into
main
from
issues/33-admin-setting-user-institution-in-keycloack-deployment
Closed
Issues/33 admin setting user institution in keycloack deployment #34
kostobog
wants to merge
11
commits into
main
from
issues/33-admin-setting-user-institution-in-keycloack-deployment
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add enum RecordState
- refactor type of PatientRecord.phase from RecordState to RecordPhase.
- method updateUserInstitution is conditional if security provider is "oidc" - method updateUser is conditional if security provider is "internal"
@blcham Is this solution ok? |
blcham
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment and that tests are failing.
blcham
deleted the
issues/33-admin-setting-user-institution-in-keycloack-deployment
branch
December 17, 2023 23:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the last commit (3c6ac92) updating UserController is relevant. The other commits are from PR #31.