Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

184 support excel import #60

Merged
merged 8 commits into from
Jul 21, 2024
Merged

184 support excel import #60

merged 8 commits into from
Jul 21, 2024

Conversation

palagdan
Copy link
Collaborator

@palagdan palagdan commented Jul 19, 2024 •
edited by blcham
Loading

@blcham blcham force-pushed the 184-support-excel-import branch from 5e1719d to fe50696 Compare July 20, 2024 10:10
@blcham
Copy link

blcham commented Jul 20, 2024 •
edited
Loading

@palagdan I have multiple comments:

    1. FYI, I rebased your PR onto main. (somebody already committed something into main)
    1. FYI, you forgot to link this PR with the issue, see how I modified this PR main comment -- 184 support excel import #60 (comment)
    1. Tests are failing, as can be seen here. Just want to make sure -- Do you know about them immediately? Do you receive emails about them?
    1. We want to reference the issue from commits, so it is clickable to the issue from here, e.g.:
      Added excelImportServiceUrl param to ConfigParam --> [kbss-cvut/record-manager-ui#184] Added excelImportServiceUrl param to ConfigParam

@blcham blcham force-pushed the 184-support-excel-import branch from 7b5579f to e1a3ede Compare July 21, 2024 04:49
blcham
blcham approved these changes Jul 21, 2024
View reviewed changes
Copy link

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my comments will be resolved by separate ticktes

src/test/java/cz/cvut/kbss/study/rest/PatientRecordControllerTest.java Outdated Show resolved Hide resolved
src/test/java/cz/cvut/kbss/study/rest/PatientRecordControllerTest.java Show resolved Hide resolved
src/main/java/cz/cvut/kbss/study/rest/PatientRecordController.java Show resolved Hide resolved
@blcham blcham self-requested a review July 21, 2024 05:27
@blcham blcham force-pushed the 184-support-excel-import branch from e1ceec1 to 31be300 Compare July 21, 2024 05:45
@blcham blcham mentioned this pull request Jul 21, 2024
Open
@blcham blcham force-pushed the 184-support-excel-import branch from 31be300 to 9746483 Compare July 21, 2024 14:06
palagdan and others added 7 commits July 21, 2024 16:23
@palagdan @blcham
[kbss-cvut/record-manager-ui#184] Add excelImportServiceUrl param to …
a320b5a 
…ConfigParam
@palagdan @blcham
[kbss-cvut/record-manager-ui#184] Add Excel type to importRecords
538cb3a
@palagdan @blcham
[kbss-cvut/record-manager-ui#184] Update importRecords endpoint for s…
1d9341f 
…upporting excel file.
@palagdan @blcham
[kbss-cvut/record-manager-ui#184] Changed handler for importing json …
4283ce6 
…and excel. Divided into two handlers
@palagdan @blcham
[kbss-cvut/record-manager-ui#184] Updated tests for importRecords
8ccea37
@blcham
[kbss-cvut/record-manager-ui#184] Fix test importRecordsJsonImportsSp…
6405787 
…ecifiedRecordsWithSpecifiedPhaseAndReturnsImportResult
@palagdan @blcham
[kbss-cvut/record-manager-ui#184] Fixed importRecordsJsonImportsSpeci…
f8ddc10 
…fiedRecordsAndReturnsImportResult importRecordsJsonReturnsConflictWhenServiceThrowsRecordAuthorNotFound
@blcham blcham force-pushed the 184-support-excel-import branch from 9746483 to 466fd68 Compare July 21, 2024 14:23
@blcham
[kbss-cvut/record-manager-ui#184] Implement detached import through T…
6fff1db 
…SV endpoint

I.e. import that is fully implemented by external service. In this case database is modified by separate service.
@blcham blcham force-pushed the 184-support-excel-import branch from 466fd68 to 6fff1db Compare July 21, 2024 15:56
@blcham blcham merged commit 86e9419 into main Jul 21, 2024
2 checks passed
@blcham blcham deleted the 184-support-excel-import branch July 21, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham Awaiting requested review from blcham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palagdan @blcham