[Upd #221] Depoluted test logs

kbss-cvut · Sep 21, 2023 · 359bd81 · 359bd81
1 parent e26f87b
commit 359bd81
Show file tree

Hide file tree

Showing 8 changed files with 172 additions and 56 deletions.
diff --git a/package.json b/package.json
@@ -88,6 +88,7 @@
     "@storybook/builder-webpack5": "^7.0.23",
     "@storybook/testing-library": "^0.2.0",
     "@storybook/testing-react": "^2.0.1",
+    "@testing-library/dom": "^9.3.3",
     "@testing-library/react": "^14.0.0",
     "@types/jsonld": "^1.5.1",
     "chromatic": "^6.5.3",

diff --git a/src/components/answer/TypeaheadAnswer.jsx b/src/components/answer/TypeaheadAnswer.jsx
@@ -131,7 +131,7 @@ const TypeaheadAnswer = (props) => {
 TypeaheadAnswer.propTypes = {
   question: PropTypes.object.isRequired,
   answer: PropTypes.object.isRequired,
-  label: PropTypes.object.isRequired,
+  label: PropTypes.oneOfType([PropTypes.string, PropTypes.object]).isRequired,
   title: PropTypes.string,
   value: PropTypes.string,
   onChange: PropTypes.func.isRequired,

diff --git a/src/components/comment/CommentView.jsx b/src/components/comment/CommentView.jsx
@@ -152,7 +152,7 @@ const CommentView = (props) => {
 };
 
 CommentView.propTypes = {
-  author: PropTypes.object.isRequired,
+  author: PropTypes.object,
   timestamp: PropTypes.string.isRequired,
   commentValue: PropTypes.string.isRequired,
   onDeleteQuestionComment: PropTypes.func.isRequired,

diff --git a/src/stories/QuestionCommentIcon.stories.tsx b/src/stories/QuestionCommentIcon.stories.tsx
@@ -32,7 +32,7 @@ const Template: ComponentStory<typeof QuestionCommentIcon> = (
   return (
     <ConfigurationContextProvider options={options}>
       <IntlContextProvider locale={locale}>
-        <QuestionCommentIcon {...args} />
+        <QuestionCommentIcon {...args} onChange={() => void undefined} />
       </IntlContextProvider>
     </ConfigurationContextProvider>
   );

diff --git a/test/__tests__/Answer.test.js b/test/__tests__/Answer.test.js
@@ -68,7 +68,12 @@ describe("Answer component", () => {
         }}
       >
         <FormGenContext.Provider value={{ getOptions, loadFormOptions }}>
-          <Answer answer={{}} question={question} onChange={onChange} />
+          <Answer
+            answer={{}}
+            question={question}
+            onChange={onChange}
+            onCommentChange={() => void undefined}
+          />
         </FormGenContext.Provider>
       </ConfigurationContext.Provider>
     );
@@ -104,12 +109,17 @@ describe("Answer component", () => {
         <FormGenContext.Provider
           value={{ getOptions, loadFormOptions: () => typeAheadOptions }}
         >
-          <Answer answer={answer} question={question} onChange={onChange} />
+          <Answer
+            answer={answer}
+            question={question}
+            onChange={onChange}
+            onCommentChange={() => void undefined}
+          />
         </FormGenContext.Provider>
       </ConfigurationContext.Provider>
     );
 
-    await waitFor(async () => {
+    await waitFor(() => {
       const typeahead = screen.getByRole("combobox");
 
       fireEvent.click(typeahead);
@@ -120,7 +130,7 @@ describe("Answer component", () => {
     });
   });
 
-  it("loads typeahead options when layout class is typeahead and no possible values are specified", () => {
+  it("loads typeahead options when layout class is typeahead and no possible values are specified", async () => {
     question[Constants.LAYOUT_CLASS].push(Constants.LAYOUT.QUESTION_TYPEAHEAD);
     const query = "SELECT * WHERE { ?x ?y ?z .}";
     question[Constants.HAS_OPTIONS_QUERY] = query;
@@ -134,13 +144,20 @@ describe("Answer component", () => {
         }}
       >
         <FormGenContext.Provider value={{ getOptions, loadFormOptions }}>
-          <Answer answer={{}} question={question} onChange={onChange} />
+          <Answer
+            answer={{}}
+            question={question}
+            onChange={onChange}
+            onCommentChange={() => void undefined}
+          />
         </FormGenContext.Provider>
       </ConfigurationContext.Provider>
     );
 
-    expect(loadFormOptions).toHaveBeenCalled();
-    expect(loadFormOptions.mock.calls[0][1]).toEqual(query);
+    await waitFor(() => {
+      expect(loadFormOptions).toHaveBeenCalled();
+      expect(loadFormOptions.mock.calls[0][1]).toEqual(query);
+    });
   });
 
   function answerWithCodeValue(value) {
@@ -166,7 +183,12 @@ describe("Answer component", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />s
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
 
@@ -204,7 +226,12 @@ describe("Answer component", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
 
@@ -231,7 +258,12 @@ describe("Answer component", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
 
@@ -258,7 +290,12 @@ describe("Answer component", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
 
@@ -289,7 +326,12 @@ describe("Answer component", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
 
@@ -319,7 +361,12 @@ describe("Answer component", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = screen.getByRole("checkbox");
@@ -345,7 +392,12 @@ describe("Answer component", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
 
@@ -373,7 +425,12 @@ describe("Answer component", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = screen.getByRole("textbox");
@@ -401,7 +458,12 @@ describe("Answer component", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = screen.getByRole("textbox");

diff --git a/test/__tests__/InputAnswer.test.js b/test/__tests__/InputAnswer.test.js
@@ -60,7 +60,12 @@ describe("InputAnswer", () => {
           options,
         }}
       >
-        <Answer question={question} answer={answer} onChange={onChange} />
+        <Answer
+          question={question}
+          answer={answer}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = component.find("input");
@@ -84,7 +89,12 @@ describe("InputAnswer", () => {
           options,
         }}
       >
-        <Answer question={question} answer={answer} onChange={onChange} />
+        <Answer
+          question={question}
+          answer={answer}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = component.find("input");
@@ -108,7 +118,12 @@ describe("InputAnswer", () => {
           options,
         }}
       >
-        <Answer question={question} answer={answer} onChange={onChange} />
+        <Answer
+          question={question}
+          answer={answer}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = component.find("input");
@@ -132,7 +147,12 @@ describe("InputAnswer", () => {
           options,
         }}
       >
-        <Answer question={question} answer={answer} onChange={onChange} />
+        <Answer
+          question={question}
+          answer={answer}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = component.find("input");
@@ -158,7 +178,12 @@ describe("InputAnswer", () => {
           options,
         }}
       >
-        <Answer question={question} answer={answer} onChange={onChange} />
+        <Answer
+          question={question}
+          answer={answer}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = component.find("input");
@@ -181,7 +206,12 @@ describe("InputAnswer", () => {
           options,
         }}
       >
-        <Answer question={question} answer={answer} onChange={onChange} />
+        <Answer
+          question={question}
+          answer={answer}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = component.find("input");

diff --git a/test/__tests__/MaskedInputAnswer.test.js b/test/__tests__/MaskedInputAnswer.test.js
@@ -48,7 +48,12 @@ describe("MaskedInputAnswer", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = component.find("input");
@@ -79,7 +84,12 @@ describe("MaskedInputAnswer", () => {
           options,
         }}
       >
-        <Answer answer={answer} question={question} onChange={onChange} />
+        <Answer
+          answer={answer}
+          question={question}
+          onChange={onChange}
+          onCommentChange={() => void undefined}
+        />
       </ConfigurationContext.Provider>
     );
     const input = component.find("input");