Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depoluted test logs #229

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Depoluted test logs #229

merged 2 commits into from
Sep 25, 2023

Conversation

LaChope
Copy link
Collaborator

@LaChope LaChope commented Sep 21, 2023

Resolves #221

@LaChope LaChope requested a review from blcham September 21, 2023 14:18
@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for s-forms-kbss ready!

Name Link
🔨 Latest commit b00a1cf
🔍 Latest deploy log https://app.netlify.com/sites/s-forms-kbss/deploys/651199babf43750008b55df7
😎 Deploy Preview https://deploy-preview-229--s-forms-kbss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please provide comment

@@ -120,7 +130,7 @@ describe("Answer component", () => {
});
});

it("loads typeahead options when layout class is typeahead and no possible values are specified", () => {
it("loads typeahead options when layout class is typeahead and no possible values are specified", async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From react documentation, a component must be prepared for assertion using act(). It is usually already integrated in React-testing librabry, but in case of asynchronous updates, it must be wrapped in waitFor()

@LaChope LaChope merged commit b00a1cf into master Sep 25, 2023
6 checks passed
@LaChope LaChope deleted the depolute-logs branch November 1, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm test polutes log with many errors
2 participants