Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JavaScript heap out of memory #235

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fixed JavaScript heap out of memory #235

merged 2 commits into from
Nov 16, 2023

Conversation

LaChope
Copy link
Collaborator

@LaChope LaChope commented Nov 15, 2023

Resolves #234

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for s-forms-kbss ready!

Name Link
🔨 Latest commit 1f4e8ac
🔍 Latest deploy log https://app.netlify.com/sites/s-forms-kbss/deploys/6555e591066e8b00083c1bdf
😎 Deploy Preview https://deploy-preview-235--s-forms-kbss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LaChope LaChope requested a review from blcham November 15, 2023 08:12
@blcham
Copy link
Collaborator

blcham commented Nov 15, 2023

FYI based on comments from developit/microbundle#870 (comment) I also investigated the size of the library (after npm run build), and it seems reasonable (right?):
image

Copy link
Collaborator

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about --target

package.json Outdated Show resolved Hide resolved
@LaChope
Copy link
Collaborator Author

LaChope commented Nov 16, 2023

FYI based on comments from developit/microbundle#870 (comment) I also investigated the size of the library (after npm run build), and it seems reasonable (right?): image

Yes, seems ok to me

@blcham blcham merged commit 5929253 into master Nov 16, 2023
7 checks passed
@blcham blcham deleted the fix-microbundle branch November 16, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to build with Microbundle
2 participants