Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sort function causing crash #238

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fixed sort function causing crash #238

merged 1 commit into from
Nov 17, 2023

Conversation

LaChope
Copy link
Collaborator

@LaChope LaChope commented Nov 16, 2023

Resolves #236

@LaChope LaChope requested a review from blcham November 16, 2023 11:44
@LaChope LaChope changed the title Fixed sort function Fixed sort function causing crash Nov 16, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for s-forms-kbss ready!

Name Link
🔨 Latest commit 608cdb9
🔍 Latest deploy log https://app.netlify.com/sites/s-forms-kbss/deploys/655600a10742220008e82dc0
😎 Deploy Preview https://deploy-preview-238--s-forms-kbss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LaChope LaChope linked an issue Nov 16, 2023 that may be closed by this pull request
Form 1 in storybook throws error #219
Closed
@blcham
Copy link
Collaborator

blcham commented Nov 17, 2023 •
edited
Loading

@LaChope, I am merging the PR and closing the related ticket. I hope it is ok to do.

@blcham blcham merged commit c22f5eb into master Nov 17, 2023
6 checks passed
@LaChope
Copy link
Collaborator Author

LaChope commented Nov 17, 2023

@LaChope, I am merging the PR and closing the related ticket. I hope it is ok to do.

@blcham yes it can be merged and ticket closed.

@LaChope LaChope deleted the fix-typeahead-sort branch November 17, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typeahead component in s-forms demo causes whole form to fail Form 1 in storybook throws error
2 participants
@LaChope @blcham