Fix RangeError: Invalid time value

[palagdan]

Fix #363

[netlify]

✅ Deploy Preview for s-forms-kbss ready!

Name	Link
🔨 Latest commit	835620a
🔍 Latest deploy log	https://app.netlify.com/sites/s-forms-kbss/deploys/67100dc3e2df5f00083e253c
😎 Deploy Preview	https://deploy-preview-364--s-forms-kbss.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[palagdan]

@blcham

I also found an error when I clicked on some of the select inputs (not all).

[blcham]

@palagdan thanks, i created #365

[blcham]

Regarding timestamp:

See also how it used to work:
#366

[blcham]

Regarding timestamp, i can think of two variants:

A)

{
      "label": "Timestamp in db",
      "@id": "http://vfn.cz/ontologies/fss-form/timestamp-in-db-q",
      "has-layout-class": ["timestamp"],
      "has_answer": "http://onto.fel.cvut.cz/ontologies/custom/model/instance#instance123456-a",
      "@type": "doc:question"
    },

or

B)

{
  "label": "Timestamp in db",
  "@id": "http://vfn.cz/ontologies/fss-form/timestamp-in-db-q",
  "has-layout-class": ["datetime"],
  "has_answer": "http://onto.fel.cvut.cz/ontologies/custom/model/instance#instance123456-a",
  "@type": "doc:question",
  "timestamp-format": "epoch-milliseconds", // or "epoch-seconds"
  "form:has-datatype": {
    "@id": "xsd:integer"
  }
}

[blcham]

@palagdan unless you have better idea I would go with variant B). It seems to me nice solution as "datetime" is rather indicating frontend properties of the component (= layout-class) not how it is stored in RDF .

There are two fundamental properties:

"has-layout-class": ["datetime"],
"timestamp-format": "epoch-milliseconds", // or "epoch-seconds"

Optional property is (it is default and it should work without it):

  "form:has-datatype": {
    "@id": "xsd:integer"
  }

You can see my whole reasoning about it in chatGPT -- https://chatgpt.com/share/67054eed-155c-8006-9c22-ea64d61cde40

[palagdan]

@blcham
Could you please check the implementation? The empty answer appears the same because the timestamp uses a datetime layout, but it stores the value in epoch milliseconds.

[palagdan]

@blcham

I investigated and found out the the problem is with jsonld-utils library that returns incorrect responses in hasValue function. That is why date and time has layout date, time and datetime because hasValue returns true.

here:

function hasValue(object, property, value) {
  return object[property] !== undefined && object[property] !== null && (object[property] === value || object[property]['@id'] === value || object[property].indexOf && object[property].indexOf(value) !== -1);
}

When object[property] is "datetime" and value is "date", the expression object[property].indexOf(value) returns 0 because the substring "date" starts at index 0 of the string "datetime". When value is time, indexOf(value) returns 4.
The function should call indexOf only on arrays, not strings.

I suggest refactoring out this library in other places as well, as it may introduce bugs elsewhere.

[blcham]

@palagdan thanks for finding the issue, @ledsoft fixed it in new version -- 0.1.3.

[palagdan]

@blcham

I removed DATETIME_NUMBER_FORMAT because it was a poor workaround for the numerical representation of the date. The resolveDateTimeFormat function should not need to handle this, as it deals with layouts, not the internal representation of the date. Now it works as expected:

• If the layout has a timestamp format, it will save the date in milliseconds, allowing for the combination of the layout and this format.
• I fixed the number conversion to the date in the last commit, making it possible to retrieve the date from the number.
• I saved the error state so we can discuss how to display it, or if we should display it at all.
• If there is no value, an error is not thrown, and the input shows the date template instead.

You can have a look at it after merging this: #371

[blcham]

Good job!