Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement icon display on keyboard focus #374

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

palagdan
Copy link
Collaborator

Resolve #319

@palagdan palagdan requested a review from blcham October 22, 2024 14:36
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for s-forms-kbss ready!

Name Link
🔨 Latest commit 927906e
🔍 Latest deploy log https://app.netlify.com/sites/s-forms-kbss/deploys/673e06e33fe30b000851617d
😎 Deploy Preview https://deploy-preview-374--s-forms-kbss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blcham blcham force-pushed the 319-help-icon-hover branch from 6aebcd5 to 4f25d94 Compare November 1, 2024 06:04
Copy link
Collaborator

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @palagdan i am little confused as i thought i have already merged it

@palagdan palagdan force-pushed the 319-help-icon-hover branch from 4f25d94 to b541fcb Compare November 19, 2024 17:31
@palagdan
Copy link
Collaborator Author

@blcham

It wasn't merged earlier. I have rebased this PR and resolved the conflicts, so it is ready to be merged now.

@palagdan palagdan requested a review from blcham November 19, 2024 17:32
@blcham blcham force-pushed the 319-help-icon-hover branch from b541fcb to 927906e Compare November 20, 2024 15:57
@blcham blcham merged commit 2849b71 into master Nov 20, 2024
7 checks passed
@blcham blcham deleted the 319-help-icon-hover branch November 20, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help/Comment icon should be shown on keyboard focus as well
2 participants