Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading module configuration do not complete #45

Closed
blcham opened this issue Aug 8, 2024 · 2 comments · Fixed by #46
Closed

Loading module configuration do not complete #45

blcham opened this issue Aug 8, 2024 · 2 comments · Fixed by #46
Assignees

Comments

@blcham
Copy link
Contributor

blcham commented Aug 8, 2024

It seems like the issue occurred after upgrading the webpack in #44.


It manifests as follows:
image

The console shows error:
image

Error 2 comes from the issue with s-forms that was resolved in kbss-cvut/s-forms@0030c82.


Problem:
It is not possible to upgrade s-forms as it is based on react: 18.2.0 while s-pipes-editor uses "react": "^16.13.1".

Solution:
It is not worth making new versions of s-forms to fix the issue, but rather upgrading s-pipes-editor to "react 18".

@blcham blcham changed the title Loading module configuration does not complete Loading module configuration do not complete Aug 8, 2024
@blcham
Copy link
Contributor Author

blcham commented Aug 8, 2024

@palagdan
I tried to add new version of s-forms without upgrading react in here -- #46. However I was not sucessfull.

@blcham
Copy link
Contributor Author

blcham commented Aug 8, 2024

This issue has "low priority" as we can live now with editor not showing module configuration.

palagdan added a commit that referenced this issue Aug 9, 2024
blcham pushed a commit that referenced this issue Aug 10, 2024
palagdan added a commit that referenced this issue Aug 12, 2024
blcham added a commit that referenced this issue Aug 12, 2024
blcham added a commit that referenced this issue Aug 12, 2024
Add s-forms css as  `import "@kbss-cvut/s-forms/css";` does not work properly in the project
blcham pushed a commit that referenced this issue Aug 12, 2024
blcham pushed a commit that referenced this issue Aug 12, 2024
blcham added a commit that referenced this issue Aug 12, 2024
blcham added a commit that referenced this issue Aug 12, 2024
Add s-forms css as  `import "@kbss-cvut/s-forms/css";` does not work properly in the project
blcham added a commit that referenced this issue Aug 12, 2024
CSS files were not loaded in docker image. It is not well solved but could be solved when switching to different build tools (e.g. webpack --> vite)
blcham added a commit that referenced this issue Aug 12, 2024
blcham added a commit that referenced this issue Aug 12, 2024
…-not-complete

[#45] Initial try to fix module configuration not loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants