[#45] Initial try to fix module configuration not loading

[blcham]

Resolves #45

[blcham]

@palagdan

Note, that to overcome issues with different react versions I used:
npm install --legacy-peer-deps

I did not investigate much, but I guess it won't be possible to fix build without upgrading react version of s-pipes-editor-ui.

Thus I would do small investigation how to upgrade to react 18 and at least list the issues here.

[palagdan]

@blcham

The problem was indeed in version of react. I updated it to the version 18.2.0 and everything works fine:

However, I don't think --legacy-peer-deps flag is a good solution. While investigating the dependency issues, I discovered that many dependencies haven't been updated in years. Updating to version 18.2.0 with this flag feels like a temporary fix rather than a long-term solution.

I've created another ticket to address the old dependencies and look for alternative libraries.

[blcham]

@palagdan,

1. is the screenshot showing how it works now? Because it looks very strange ... is there any error in console?
2. of course I would like to remove --legacy-peer-deps as well

[palagdan]

@blcham
No, there are no errors in the console. I noticed that you changed a dependency for s-forms. Could the problem be related to that?

[blcham]

test it

…

On Sat, 10 Aug 2024 at 17:17, Daniil Palagin ***@***.***> wrote: @blcham <https://github.com/blcham> No, there are no errors in the console. I noticed that you changed a dependency for s-forms. Could the problem be related to that? — Reply to this email directly, view it on GitHub <#46 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6HK7IRPTB4YE4UENJWAB3ZQYVH3AVCNFSM6AAAAABMGXOMB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGE4DGNZVGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[palagdan]

@blcham
I investigated this problem and here is what I found:

Before updating React to version 18:

The "Error Loading SForms..." message appears in all examples except for the Hello-World example.
When attempting to call the loading module configuration in the examples where it fails, the response from S-Forms appears valid and should work, but it does not.

In the Hello-World example, which is the only one where it works, submitting the form results in a request that is missing parameters (firstName, lastName), leading to an error.

After updating react to version 18:

The infinite "Loading SForms" error no longer occurs, but the form is still not working correctly as it fails to send the parameters in the request.

[palagdan]

@blcham
I also investigated the issues with the incorrect forms and found some unusual results. Initially, I tested different packages and observed varying outcomes. At first, the Hello-World example returned the correct forms, while the other examples did not. I tested with different Docker builds, including ones published a year ago. However, when I tried the latest build, all forms were correct in all examples, except for the constraint validation example, which initially returned an incorrect form but then corrected itself after a few minutes. I’m quite confused by these inconsistencies. Could we review this together?