Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put nginx in front of the services #63

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Put nginx in front of the services #63

merged 7 commits into from
Sep 18, 2024

Conversation

palagdan
Copy link
Collaborator

@palagdan palagdan commented Sep 9, 2024

Resolves #50

@palagdan
Copy link
Collaborator Author

palagdan commented Sep 9, 2024 •
edited
Loading

@blcham

All services seems to be working with nginx except for db-server. I tried to fix it, but I don't know what the problem.
Screenshot from 2024-09-09 17-14-30

I fixed it by adding :

GDB_JAVA_OPTS: "-Dgraphdb.external-url=${PUBLIC_ORIGIN:-http://localhost:${INTERNAL_HOST_PORT:-1235}}/services/db-server"

@palagdan palagdan requested a review from blcham September 9, 2024 15:17
@palagdan
Copy link
Collaborator Author

palagdan commented Sep 17, 2024 •
edited
Loading

@blcham

Screenshot from 2024-09-17 20-38-01
The backend is working correctly. I might have requested the wrong path earlier.

blcham
blcham requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
deploy/docker-compose.yml Outdated Show resolved Hide resolved
deploy/docker-compose.yml Outdated Show resolved Hide resolved
deploy/docker-compose.yml Outdated Show resolved Hide resolved
blcham
blcham reviewed Sep 17, 2024
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
blcham
blcham reviewed Sep 17, 2024
View reviewed changes
deploy/nginx/error.html Outdated Show resolved Hide resolved
@blcham
Copy link
Contributor

blcham commented Sep 18, 2024

@palagdan watch out, i force-pushed (most likely it was not good idea) just to fix formating of nginx.conf

@blcham blcham self-requested a review September 18, 2024 08:38
blcham
blcham requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for refactoring docker-compose.yml, it was much easier to read now. Just one comment related SERVICE_URL after which we can merge.

deploy/docker-compose.yml Outdated Show resolved Hide resolved
@blcham blcham merged commit 616b4be into master Sep 18, 2024
1 check passed
@blcham blcham deleted the 50-nginx-deploy branch September 18, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put nginx in front of s-pipes-editor-ui and other services
2 participants
@palagdan @blcham