Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPD] Add argument declarations to :execute-greeting function in doc/examples/hello-world/hello-world.sms.ttl #217

Merged

Conversation

kostobog
Copy link
Contributor

Fix for #213

@blcham blcham self-requested a review September 28, 2023 20:30
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i believe you missed parameters (see my suggestions)

doc/examples/hello-world/hello-world.sms.ttl Outdated Show resolved Hide resolved
doc/examples/hello-world/hello-world.sms.ttl Outdated Show resolved Hide resolved
@blcham blcham merged commit d864986 into main Sep 29, 2023
2 checks passed
@blcham
Copy link
Contributor

blcham commented Sep 29, 2023

@kostobog FYI, see my last 2 commits

@blcham blcham deleted the issues/issue-213-add-missing-parameters-of-functions-in-examples branch August 14, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants