Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md to provide instructions for running the SPipes Dock… #242

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

palagdan
Copy link
Collaborator

@palagdan palagdan commented Jul 10, 2024

Resolves #238.

…er container without mounting directories, and added optional steps for mounting directories on both Linux and Windows.

@palagdan palagdan requested a review from blcham July 11, 2024 12:59
@blcham
Copy link
Contributor

blcham commented Jul 11, 2024

I will review during weekend

Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment to discuss. After resolution I would make the description more concise -- i.e. have one guide with steps and differentiate only within steps (regarding Windows and Linux)

README.md Outdated Show resolved Hide resolved
palagdan and others added 2 commits July 17, 2024 07:38
…ndows

I.e. refactoring instructions for running the SPipes Docker container without mounting directories, and added optional steps for mounting directories on both Linux and Windows.
@blcham blcham force-pushed the improvement/238-docker-doc-update branch from 589d339 to 97c37da Compare July 17, 2024 08:28
@blcham
Copy link
Contributor

blcham commented Jul 17, 2024

@palagdan I reformulated a little what you wrote; now I consider it final ... let me know what u think

@palagdan
Copy link
Collaborator Author

@palagdan I reformulated a little what you wrote; now I consider it final ... let me know what u think

Thank you for the update. I agree with your changes and consider it final as well.

@blcham blcham merged commit fdad9ad into main Jul 17, 2024
2 checks passed
@blcham blcham deleted the improvement/238-docker-doc-update branch July 17, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running dockerized image is not properly explained
2 participants