Fixes scripts not updating on change in development mode #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSattrtand
changed the base branch from
main
to
231-improve-query-parse-error-logging
MSattrtand
changed the base branch from
231-improve-query-parse-error-logging
to
main
MSattrtand
force-pushed
the
227-fixes-scripts-not-updating-on-change
branch
from
de19731 to
5c827bd
Compare
blcham
force-pushed
the
227-fixes-scripts-not-updating-on-change
branch
from
79cc0dd to
bb83ef1
Compare
blcham
reviewed
Jan 8, 2025
| @@ -88,7 +88,7 @@ public Module loadModule(final String moduleId, | |||
|
|
|||
| // TODO check moduleTypeUri | |||
|
|
|||
| return PipelineFactory.loadPipeline(scriptsRepository.getResource(resourceUri, resourceContextUri)); | |||
| return PipelineFactory.loadModule(scriptsRepository.getResource(resourceUri, resourceContextUri)); | |||
There was a problem hiding this comment.
I am not sure that this is ok, i will check
There was a problem hiding this comment.
loadPipeline() loads the script from the saved pipeline, not from the file we've changed, if I remember correctly. So, it will use the old version of the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #227