Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#294] We now can disable previous row injection #296

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MSattrtand
Copy link
Collaborator

Resolves #294

@MSattrtand MSattrtand requested a review from blcham January 9, 2025 12:59
@MSattrtand
Copy link
Collaborator Author

MSattrtand commented Jan 9, 2025

image
Also, it would probably make sense to add a new predicate "http://onto.fel.cvut.cz/ontologies/lib/module/apply-construct-with-chunked-values/enable-previous-binding", so we could use it in all-modules.ttl (not sure if it is not an autogenerated file) the same way as chunk-size, e.g.
If it's not already there, of course

Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just bad naming convention, moreover i decided it would be nice to write also test for it ... please have a look at other modules how this is done

Comment on lines 62 to 63
@Parameter(iri = TYPE_PREFIX + "enable-previous-binding", comment = "Default is true.")
private boolean UsePreviousBinding = DEFAULT_USE_PREVIOUS_BINDING_VALUE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Parameter(iri = TYPE_PREFIX + "enable-previous-binding", comment = "Default is true.")
private boolean UsePreviousBinding = DEFAULT_USE_PREVIOUS_BINDING_VALUE;
@Parameter(iri = TYPE_PREFIX + "extend-select-query-result-with-previous-binding", comment = "Default is true.")
private boolean isExtendSelectQueryResultWithPreviousBinding = true;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. UsePreviousBinding -- does not obey java nameing conventions for java fields
    • i suggested something else
  2. Do not use constant DEFAULT_USE_PREVIOUS_BINDING_VALUE, it is legacy way to do it. Moreover remove also DEFAULT_CHUNK_SIZE

@blcham
Copy link
Contributor

blcham commented Jan 9, 2025

image Also, it would probably make sense to add a new predicate "http://onto.fel.cvut.cz/ontologies/lib/module/apply-construct-with-chunked-values/enable-previous-binding", so we could use it in all-modules.ttl (not sure if it is not an autogenerated file) the same way as chunk-size, e.g. If it's not already there, of course

it is auto generated, but not sure if it works right now correctly ... thanks for mentioning it ... there is not need to add it to ttl file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to disable previous row injection into apply-construct-with-chunked-values
2 participants