-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#294] We now can disable previous row injection #296
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just bad naming convention, moreover i decided it would be nice to write also test for it ... please have a look at other modules how this is done
@Parameter(iri = TYPE_PREFIX + "enable-previous-binding", comment = "Default is true.") | ||
private boolean UsePreviousBinding = DEFAULT_USE_PREVIOUS_BINDING_VALUE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Parameter(iri = TYPE_PREFIX + "enable-previous-binding", comment = "Default is true.") | |
private boolean UsePreviousBinding = DEFAULT_USE_PREVIOUS_BINDING_VALUE; | |
@Parameter(iri = TYPE_PREFIX + "extend-select-query-result-with-previous-binding", comment = "Default is true.") | |
private boolean isExtendSelectQueryResultWithPreviousBinding = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- UsePreviousBinding -- does not obey java nameing conventions for java fields
- i suggested something else
- Do not use constant DEFAULT_USE_PREVIOUS_BINDING_VALUE, it is legacy way to do it. Moreover remove also DEFAULT_CHUNK_SIZE
it is auto generated, but not sure if it works right now correctly ... thanks for mentioning it ... there is not need to add it to ttl file |
Resolves #294