Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlighting when config entry key has the same name as import module #1849

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Feb 5, 2025

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13157726269

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 70.343%

Totals Coverage Status
Change from base Build 13156382562: 0.02%
Covered Lines: 52555
Relevant Lines: 74712

💛 - Coveralls

@He1pa He1pa added semantic Issues or PRs related to kcl semantic and checker ide Issues or PRs related to kcl LSP and IDE plugins lsp fix labels Feb 6, 2025
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit d8964b2 into main Feb 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix ide Issues or PRs related to kcl LSP and IDE plugins lsp semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
3 participants