Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: enhance fmt tool. #1850

Merged
merged 2 commits into from
Feb 7, 2025
Merged

enhance: enhance fmt tool. #1850

merged 2 commits into from
Feb 7, 2025

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Feb 6, 2025

1.save empty line between comments,
2. fix logicc of empty line between stmt

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

fmt

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

He1pa added 2 commits February 6, 2025 18:00
Signed-off-by: he1pa <[email protected]>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13177385716

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 70.347%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 1 84.97%
Totals Coverage Status
Change from base Build 13174900010: 0.002%
Covered Lines: 52563
Relevant Lines: 74720

💛 - Coveralls

@Peefy Peefy merged commit 763724d into main Feb 7, 2025
13 checks passed
@Peefy Peefy deleted the enhance_fmt branch February 7, 2025 12:36
@legal90
Copy link

legal90 commented Feb 7, 2025

Thank you very much for the fix, @He1pa !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable auto-removal of empty line
4 participants